[GitHub] [geode-native] pivotal-jbarrett commented on a diff in pull request #954: GEODE-10218: Allow server debug

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on code in PR #954:
URL: https://github.com/apache/geode-native/pull/954#discussion_r869645866


##########
clicache/integration-test2/GfshTest.cs:
##########
@@ -77,13 +77,16 @@ public void StartLocatorStringsTest()
                 .withSslKeyStore("some/path/keystore.jks")
                 .withSslKeyStorePassword("password1")
                 .withSslTrustStore("some/path/truststore.jks")
-                .withSslTrustStorePassword("password2");
+                .withSslTrustStorePassword("password2")
+                .withDebugAgent(true, "address");
             s = locator.ToString();
+            var withAttachPortRemoved = s.Substring(0, s.LastIndexOf(":", s.Length-1, 6));

Review Comment:
   "attachPort"?



##########
cppcache/integration/framework/Cluster.h:
##########
@@ -141,6 +142,9 @@ class Cluster {
   Cluster(InitialLocators initialLocators, InitialServers initialServers,
           UseIpv6 useIpv6 = UseIpv6{false});
 
+  Cluster(InitialLocators initialLocators, InitialServers initialServers,
+          UseDebugAgent allowAttach);

Review Comment:
   rename variable.



##########
cppcache/integration/framework/Cluster.h:
##########
@@ -124,6 +124,7 @@ using Password = NamedType<std::string, struct PasswordParameter>;
 using CacheXMLFiles =
     NamedType<std::vector<std::string>, struct CacheXMLFilesParameter>;
 using UseIpv6 = NamedType<bool, struct UseIpv6Parameter>;
+using UseDebugAgent = NamedType<bool, struct AllowAttachParameter>;

Review Comment:
   Rename struct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org