[jira] [Commented] (KAFKA-4248) Consumer can return data from old regex subscription in poll()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15543436#comment-15543436 ] 

ASF GitHub Bot commented on KAFKA-4248:
---------------------------------------

GitHub user hachikuji opened a pull request:

    https://github.com/apache/kafka/pull/1954

    KAFKA-4248: Consumer should rematch regex immediately in subscribe

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka rematch-regex-on-subscribe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1954
    
----
commit 335cc04efa6905ec812ef3ba14985b62c536933e
Author: Jason Gustafson <ja...@confluent.io>
Date:   2016-10-03T20:03:25Z

    KAFKA-4248: Consumer should rematch regex immediately in subscribe

----


> Consumer can return data from old regex subscription in poll()
> --------------------------------------------------------------
>
>                 Key: KAFKA-4248
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4248
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>             Fix For: 0.10.1.0
>
>
> Because we only update the subscription from the metadata listener currently, it is possible when the user changes regex subscriptions to receive data from the old subscription. To fix this, we need to ensure that we rematch the new regex against the current metadata



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)