You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/04/22 02:06:58 UTC
[GitHub] [incubator-pinot] asdf2014 commented on a change in pull request #6826: Using correct placeholder for dimension table data manager
asdf2014 commented on a change in pull request #6826:
URL: https://github.com/apache/incubator-pinot/pull/6826#discussion_r618028349
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##########
@@ -116,7 +116,7 @@ public void removeSegment(String segmentName) {
_logger.info("Successfully removed segment {} and reloaded lookup table: {}", segmentName, getTableName());
} catch (Exception e) {
throw new RuntimeException(String
- .format("Error reloading lookup table after segment remove ({}) for table: {}", segmentName, getTableName()),
+ .format("Error reloading lookup table after segment remove (%s) for table: %s", segmentName, getTableName()),
Review comment:
Emm... What's the difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org