[GitHub] [incubator-mxnet] yinghu5 commented on a change in pull request #14829: Fix the incorrect MKLDNN/MKL logic in cmake

[GitBox <gi...@apache.org>]

yinghu5 commented on a change in pull request #14829: Fix the incorrect MKLDNN/MKL logic in cmake 
URL: https://github.com/apache/incubator-mxnet/pull/14829#discussion_r280978549
 
 

 ##########
 File path: cmake/Modules/FindMKL.cmake
 ##########
 @@ -43,55 +43,7 @@ endif()
 # ---[ Root folders
 set(INTEL_ROOT "/opt/intel" CACHE PATH "Folder contains intel libs")
 
-if(USE_MKLDNN)
 
 Review comment:
   @Chancebair . @lebeg  thank you a lot for the review.   Yes, we actually need full MKL package install on CI machine.  There are mainly two factors , which 
   1)  MKLDNN will don't depend on the MKLML in the future,
   2) second, but important, MXNET will use more MKL functions other than in MKLML. 
   So we decide to unlock MKLDNN (MKLML) and MKL dependency, which means, 
   use MKLDNN and USE_BLAS=mkl completely independent. 
   1)MKLDNN is on, it will download MKLML automatically. doesn't use full MKL package. 
   2)  when USE_BLAS=mkl,  only use the full MKL. (MKL_ROOT). won't detect  MKLML (from MKLDNN). 
   
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services