You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/03/21 23:58:36 UTC

[GitHub] dubee commented on a change in pull request #3479: Makes wskadmin python2 and python3 compatible

dubee commented on a change in pull request #3479: Makes wskadmin python2 and python3 compatible
URL: https://github.com/apache/incubator-openwhisk/pull/3479#discussion_r176275846
 
 

 ##########
 File path: tools/admin/wskadmin
 ##########
 @@ -32,7 +32,10 @@ import sys
 import traceback
 import uuid
 import wskprop
-import urllib
+if (sys.version_info > (3, 0)):
 
 Review comment:
   Should this be a comparison of `>=` instead of `>`? Same applies to the below occurrences. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services