You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "volatilemolotov (via GitHub)" <gi...@apache.org> on 2023/07/05 15:15:18 UTC

[GitHub] [beam] volatilemolotov opened a new pull request, #27357: fix repo and add paths to push trigger

volatilemolotov opened a new pull request, #27357:
URL: https://github.com/apache/beam/pull/27357

   - Fixes registry path for credential helper
   - Adds paths to push trigger
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on a diff in pull request #27357: fix repo and add paths to push trigger

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27357:
URL: https://github.com/apache/beam/pull/27357#discussion_r1253267727


##########
.github/workflows/build_runner_image.yml:
##########
@@ -21,12 +21,13 @@ name: Build and Version Runner Docker Image
 on:
   push:
     branches: ['master']
+    paths: ['.github/gh-actions-self-hosted-runners/arc/images/**']

Review Comment:
   Should we also include this file in the paths?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on a diff in pull request #27357: fix repo and add paths to push trigger

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27357:
URL: https://github.com/apache/beam/pull/27357#discussion_r1253277845


##########
.github/workflows/build_runner_image.yml:
##########
@@ -21,12 +21,13 @@ name: Build and Version Runner Docker Image
 on:
   push:
     branches: ['master']
+    paths: ['.github/gh-actions-self-hosted-runners/arc/images/**']

Review Comment:
   > Its hard to confirm but from docs on pull_request_target trigger
   This event runs in the context of the base of the pull request
   which i think means that the workflow in target will be run instead of the incoming code. Think that makes it moot to run
   
   This is for the push event to master, not for the pull request event so I think it should still run on the changed code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on a diff in pull request #27357: fix repo and add paths to push trigger

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27357:
URL: https://github.com/apache/beam/pull/27357#discussion_r1253279143


##########
.github/workflows/build_runner_image.yml:
##########
@@ -21,12 +21,13 @@ name: Build and Version Runner Docker Image
 on:
   push:
     branches: ['master']
+    paths: ['.github/gh-actions-self-hosted-runners/arc/images/**']

Review Comment:
   Basically, if we make a change to the workflow that impacts the container, I want that new container to get pushed after the PR is merged



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] volatilemolotov commented on a diff in pull request #27357: fix repo and add paths to push trigger

Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on code in PR #27357:
URL: https://github.com/apache/beam/pull/27357#discussion_r1253280410


##########
.github/workflows/build_runner_image.yml:
##########
@@ -21,12 +21,13 @@ name: Build and Version Runner Docker Image
 on:
   push:
     branches: ['master']
+    paths: ['.github/gh-actions-self-hosted-runners/arc/images/**']

Review Comment:
   For push it makes sense. Ill add it 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm merged pull request #27357: fix repo and add paths to push trigger

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #27357:
URL: https://github.com/apache/beam/pull/27357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] volatilemolotov commented on a diff in pull request #27357: fix repo and add paths to push trigger

Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on code in PR #27357:
URL: https://github.com/apache/beam/pull/27357#discussion_r1253270238


##########
.github/workflows/build_runner_image.yml:
##########
@@ -21,12 +21,13 @@ name: Build and Version Runner Docker Image
 on:
   push:
     branches: ['master']
+    paths: ['.github/gh-actions-self-hosted-runners/arc/images/**']

Review Comment:
   Good question. Do we want it to trigger when changing the workflow itself?
   
   Should this be common for all workflows? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on a diff in pull request #27357: fix repo and add paths to push trigger

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27357:
URL: https://github.com/apache/beam/pull/27357#discussion_r1253276235


##########
.github/workflows/build_runner_image.yml:
##########
@@ -21,12 +21,13 @@ name: Build and Version Runner Docker Image
 on:
   push:
     branches: ['master']
+    paths: ['.github/gh-actions-self-hosted-runners/arc/images/**']

Review Comment:
   Definitely yes for this one. Probably yes for other workflows as well, though I feel less strongly about ones that don't have external effects like this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] volatilemolotov commented on a diff in pull request #27357: fix repo and add paths to push trigger

Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on code in PR #27357:
URL: https://github.com/apache/beam/pull/27357#discussion_r1253276205


##########
.github/workflows/build_runner_image.yml:
##########
@@ -21,12 +21,13 @@ name: Build and Version Runner Docker Image
 on:
   push:
     branches: ['master']
+    paths: ['.github/gh-actions-self-hosted-runners/arc/images/**']

Review Comment:
   Its hard to confirm but from docs on `pull_request_target` trigger
   ```This event runs in the context of the base of the pull request``` 
   which i think means that the workflow in target will be run instead of the incoming code. Think that makes it moot to run



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on a diff in pull request #27357: fix repo and add paths to push trigger

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27357:
URL: https://github.com/apache/beam/pull/27357#discussion_r1253269142


##########
.github/workflows/build_runner_image.yml:
##########
@@ -21,12 +21,13 @@ name: Build and Version Runner Docker Image
 on:
   push:
     branches: ['master']
+    paths: ['.github/gh-actions-self-hosted-runners/arc/images/**']

Review Comment:
   (to be clear, I mean `.github/workflows/build_runner_image.yml`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org