You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by mshields822 <gi...@git.apache.org> on 2016/04/06 18:58:40 UTC

[GitHub] incubator-beam pull request: [BEAM-162] Merging with closed window...

GitHub user mshields822 opened a pull request:

    https://github.com/apache/incubator-beam/pull/135

    [BEAM-162] Merging with closed windows less sensitive to bundle partioning

    This change also rejects elements for windows which are closed before merging. 
    (Rejecting elements which end up in a closed window post-merging is still there.)
    
    Idea is rejecting post-merge is necessary so that we never emit elements for a closed window, and rejecting pre-merge is necessary so that the result is invariant on bundle repartioning. 
    
    However:
     - We want to abandon closable triggers.
     - The notion of invariance on bundle repartioning is already unsupportable for most of our triggers.
    So I'd be fine if we give up on this one.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mshields822/incubator-beam beam-162

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
    
----
commit e1df0f2cdae123df301d2b8cebf42931852fe6b8
Author: Mark Shields <ma...@google.com>
Date:   2016-04-05T22:12:16Z

    Formatting fiddles

commit 65874af3abf35eed66976b47f9712eec4e06304c
Author: Mark Shields <ma...@google.com>
Date:   2016-04-06T04:20:06Z

    Also reject closed pre-merged.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request: [BEAM-162] Merging with closed window...

Posted by mshields822 <gi...@git.apache.org>.
Github user mshields822 closed the pull request at:

    https://github.com/apache/incubator-beam/pull/135


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---