You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by likitha <gi...@git.apache.org> on 2015/07/02 12:28:19 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...

GitHub user likitha opened a pull request:

    https://github.com/apache/cloudstack/pull/555

    CLOUDSTACK-8608. System VM's failed to start due to permissions issue.

    …instance.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/likitha/cloudstack CLOUDSTACK-8608

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #555
    
----
commit 7b87e8a4184c046917f71627db9a20871ae981b4
Author: Likitha Shetty <li...@citrix.com>
Date:   2015-04-20T12:59:55Z

    CLOUDSTACK-8608. System VM's failed to start due to permissions issue.
    Provide permissions to template folder when mounted on management server.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/555#discussion_r34777747
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java ---
    @@ -697,6 +699,22 @@ private String setupMountPoint(String parent) {
             return mountPoint;
         }
     
    +    @Override
    +    public synchronized void setSystemVmTmpltPermission(String mountPoint) {
    +        if (!s_isSystemVmTmpltPermissionSet) {
    +            s_logger.debug("Set permissions for " + mountPoint);
    +            String result = null;
    +            Script script = new Script(true, "chmod", _timeout, s_logger);
    +            script.add("-R", "0777", mountPoint);
    +            result = script.execute();
    +            if (result != null) {
    +                s_logger.warn("Unable to set permissions for " + mountPoint + " due to " + result);
    +            } else {
    +                s_isSystemVmTmpltPermissionSet = true;
    +            }
    --- End diff --
    
    instance write-access to a static, even when in a synchronised block of code does not make for a good pattern. There is no guarantee that some other (synchronised) block accesses it as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/555#issuecomment-129227012
  
    Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #555: CLOUDSTACK-8608. System VM's failed to start due to p...

Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:

    https://github.com/apache/cloudstack/pull/555
  
    Continuing with the code changes here in a new PR #1875. This PR will be closed when PR #1875 is merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...

Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/555#issuecomment-121844265
  
    Travis failed due to a timeout.
    
    I will have a look at the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack/pull/555#issuecomment-216186000
  
    tag:vmware-pickup


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---