You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/11/13 14:16:21 UTC
[GitHub] [mynewt-nimble] sjanc opened a new pull request #883: nimble/ll: Use jrand48 for pseudo random generator
sjanc opened a new pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883
Don't use rand() for for pseudo random generation as this shares global
state. Use jrand48 instead and provide wrapper for late initialization.
This is to avoid seeding on init beacouse trng might not be accessible
yet.
This also means LL code will no longer seed stdlib srand() on init as
this should be application responsibility anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#issuecomment-726789126
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#issuecomment-726789126
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] benpicco commented on a change in pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
benpicco commented on a change in pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#discussion_r524000084
##########
File path: nimble/controller/src/ble_ll_rand.c
##########
@@ -20,6 +20,7 @@
#include <stdint.h>
Review comment:
```suggestion
#define _XOPEN_SOURCE
#include <stdint.h>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#issuecomment-727902523
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#issuecomment-727859550
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#issuecomment-727859550
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] benpicco commented on a change in pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
benpicco commented on a change in pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#discussion_r524000084
##########
File path: nimble/controller/src/ble_ll_rand.c
##########
@@ -20,6 +20,7 @@
#include <stdint.h>
Review comment:
```suggestion
#define _XOPEN_SOURCE
#include <stdint.h>
```
to make `jrand48()` available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#issuecomment-726988934
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #883: nimble/ll: Use jrand48 for pseudo random generator
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #883:
URL: https://github.com/apache/mynewt-nimble/pull/883#issuecomment-726988934
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org