You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/12/13 16:49:41 UTC
[PR] [MNG-7963] Clean up the build [maven]
cstamas opened a new pull request, #1340:
URL: https://github.com/apache/maven/pull/1340
Changes:
* remove hamcrest 1.3 from scope
* set proc:none to prevent warnings (Sisu APT is on classpath), we do not use annotation processing, we produce Sisu index explicitly.
* remove some redundant elements from POMs
---
https://issues.apache.org/jira/browse/MNG-7963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7963] Clean up the build [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1340:
URL: https://github.com/apache/maven/pull/1340#discussion_r1426570213
##########
maven-embedder/src/main/java/org/eclipse/sisu/plexus/PlexusXmlBeanConverter.java:
##########
@@ -43,6 +42,7 @@
import org.codehaus.plexus.util.xml.pull.MXParser;
import org.codehaus.plexus.util.xml.pull.XmlPullParser;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.sisu.Priority;
Review Comment:
Historically, Sisu relied on JSR250 and alike annotations, but as time passed, it implemented more and more of "own" annotations. Since a while (0.3.4 or so) it has it all in own namespace as well. If you look at history of this PR, you will see that I even removed `java.annotations:javax.annotations-api` from Maven completely, and Maven has happy about it, but we have one IT that uses it, the MavenITmng6084Jsr250PluginTest, hence I had to undo that change.
Given Sisu is "internal implementation detail" of Maven Core, I think using Sisu annotations _within_ Maven core is best/better, than relying on something else.
So this PR just makes sure that Maven Core uses Sisu annotations instead of something else, while the semantics 100% remains same as test/ITs prove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7963] Clean up the build [maven]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #1340:
URL: https://github.com/apache/maven/pull/1340#discussion_r1426023741
##########
maven-embedder/src/main/java/org/eclipse/sisu/plexus/PlexusXmlBeanConverter.java:
##########
@@ -43,6 +42,7 @@
import org.codehaus.plexus.util.xml.pull.MXParser;
import org.codehaus.plexus.util.xml.pull.XmlPullParser;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.sisu.Priority;
Review Comment:
out of curiosity why changing this package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7963] Clean up the build [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1340:
URL: https://github.com/apache/maven/pull/1340#discussion_r1426570213
##########
maven-embedder/src/main/java/org/eclipse/sisu/plexus/PlexusXmlBeanConverter.java:
##########
@@ -43,6 +42,7 @@
import org.codehaus.plexus.util.xml.pull.MXParser;
import org.codehaus.plexus.util.xml.pull.XmlPullParser;
import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
+import org.eclipse.sisu.Priority;
Review Comment:
Historically, Sisu relied on JSR250 and alike annotations, but as time passed, it implemented more and more of "own" annotations. Since a while (0.3.4 or so) it has it all in own namespace as well. If you look at history of this PR, you will see that I even removed `java.annotations:javax.annotations-api` from Maven completely, and Maven has happy about it, but we have one IT that uses it, the MavenITmng6084Jsr250PluginTest, hence I had to undo that change.
Given Sisu is "internal implementation detail" of Maven Core, I think using Sisu annotations _within_ Maven core is best/better, than relying on something else.
So this PR just makes sure that Maven Core uses Sisu annotations instead of something else, while the semantics 100% remains same as test/ITs prove. Again, the "something else" is most probably just debt, as _originally_ (3.0, 3.1?) there were ONLY JSR250 annotations to be used, but Sisu changed in this respect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7963] Clean up the build [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1340:
URL: https://github.com/apache/maven/pull/1340#issuecomment-1854346371
One requirement I have for the builds is that a subsequent run of `mvn package` does not change the jars if you run it. Basically, running `ls -ltr **/*.jar` should give you jars which are all older than the time you launched the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7963] Clean up the build [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1340:
URL: https://github.com/apache/maven/pull/1340#issuecomment-1854494787
Ok, was unaware of IT MavenITmng6084Jsr250PluginTest, it is only failed. Will return javax.annotation-api then...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-7963] Clean up the build [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #1340:
URL: https://github.com/apache/maven/pull/1340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org