[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2777: [Alter] Add more schema change to varchar type

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #2777: [Alter] Add more schema change to varchar type
URL: https://github.com/apache/incubator-doris/pull/2777#discussion_r367768634
 
 

 ##########
 File path: be/test/olap/schema_change_test.cpp
 ##########
 @@ -212,6 +212,47 @@ class TestColumn : public testing::Test {
         ASSERT_EQ(_column_writer->create_row_index_entry(), OLAP_SUCCESS);
     }
 
+    void test_convert_to_varchar(std::string type_name, int type_size, const std::string& value, OLAPStatus expected_st) {
 
 Review comment:
   std::string& type_name

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org