You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/09/29 21:07:28 UTC

[GitHub] [solr] madrob commented on a change in pull request #315: SOLR-15642: ZkControllerTest no longer runs correctly due to various …

madrob commented on a change in pull request #315:
URL: https://github.com/apache/solr/pull/315#discussion_r718885312



##########
File path: solr/core/src/test/org/apache/solr/cloud/ZkControllerTest.java
##########
@@ -187,11 +187,11 @@ public void testGetHostName() throws Exception {
       } finally {
         if (zkController != null)
           zkController.close();
+        if (cc != null) {

Review comment:
       moving the declaration of `cc` to the assignment at line 179 would make the error here more clear. same for the other usage that you changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org