You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/10 04:34:21 UTC

[GitHub] [pulsar] sijie commented on pull request #7143: Add broker interceptor for Intercepting all Pulsar command and REST API requests

sijie commented on pull request #7143:
URL: https://github.com/apache/pulsar/pull/7143#issuecomment-641714632


   @merlimat @jerrypeng I think this is to set up the framework so the broker can load interceptors from NAR packages. The interface is very basic and only focuses on intercepting connections. We don't expect this interface to the public at this moment. It is the first step to implement interceptors. We should iterate the interface and add the pull request #7159 that @merlimat sent for intercepting per restful call.
   
   Since these two pull requests have different focuses (NAR class loading, connection level interception vs per-rest-call interception) and they can be merged together, I don't see we need to block one pull request for the other pull request. Especially in any case, we need to load the plugin from NAR package just as what we did for other plugins, correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org