You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/08 01:51:06 UTC

[GitHub] [incubator-seatunnel] legendtkl opened a new pull request, #1825: [Bugfix][seatunnel-core-flink-sql] fix configuration parsing from sql…

legendtkl opened a new pull request, #1825:
URL: https://github.com/apache/incubator-seatunnel/pull/1825

   ## Purpose of this pull request
   fix https://github.com/apache/incubator-seatunnel/issues/1824
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1825: [Bugfix][seatunnel-core-flink-sql] fix configuration parsing from sql…

Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1825:
URL: https://github.com/apache/incubator-seatunnel/pull/1825#issuecomment-1120434549

   > > Hi, @ruanwenjun , this bug is caused by this PR #1757 .
   > > I can add a missing UT for this bug, but missing UTs complement for Flink SQL module might take some effort. I propose to do this stories in another PR. IT you mentioned might be a good idea.
   > > What do you think?
   > > Thanks, Kelu
   > 
   > It's OK to me, we can create a issue to track this. In fact, most of the current bugs are caused by missing test case.
   
   Yes, I will take a overvie


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1825: [Bugfix][seatunnel-core-flink-sql] fix configuration parsing from sql…

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #1825:
URL: https://github.com/apache/incubator-seatunnel/pull/1825


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1825: [Bugfix][seatunnel-core-flink-sql] fix configuration parsing from sql…

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1825:
URL: https://github.com/apache/incubator-seatunnel/pull/1825#issuecomment-1120350388

   Could you please add UT to cover the cases of flink sql conf? I hope we can fix these in one PR. Or you can add IT based on #1828 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] legendtkl closed pull request #1825: [Bugfix][seatunnel-core-flink-sql] fix configuration parsing from sql…

Posted by GitBox <gi...@apache.org>.
legendtkl closed pull request #1825: [Bugfix][seatunnel-core-flink-sql] fix configuration parsing from sql…
URL: https://github.com/apache/incubator-seatunnel/pull/1825


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1825: [Bugfix][seatunnel-core-flink-sql] fix configuration parsing from sql…

Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1825:
URL: https://github.com/apache/incubator-seatunnel/pull/1825#issuecomment-1120358709

   Hi, @ruanwenjun , this bug is caused by this PR https://github.com/apache/incubator-seatunnel/pull/1757 .
   
   I can add a missing UT for this bug, but missing UTs complement for Flink SQL module might take some effort. I propose to do this stories in another PR. 
   
   What do you think?
   
   Thanks,
   Kelu


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1825: [Bugfix][seatunnel-core-flink-sql] fix configuration parsing from sql…

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1825:
URL: https://github.com/apache/incubator-seatunnel/pull/1825#issuecomment-1120382542

   > Hi, @ruanwenjun , this bug is caused by this PR #1757 .
   > 
   > I can add a missing UT for this bug, but missing UTs complement for Flink SQL module might take some effort. I propose to do this stories in another PR. IT you mentioned might be a good idea.
   > 
   > What do you think?
   > 
   > Thanks, Kelu
   
   It's OK to me, we can create a issue to track this. In fact, most of the current bugs are caused by missing test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org