You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "ruanwenjun (via GitHub)" <gi...@apache.org> on 2023/07/09 15:27:08 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #14487: Use jvm_args_env.sh to set JVM args

ruanwenjun commented on code in PR #14487:
URL: https://github.com/apache/dolphinscheduler/pull/14487#discussion_r1257501666


##########
docs/docs/en/architecture/configuration.md:
##########
@@ -86,15 +90,16 @@ The directory structure of DolphinScheduler is as follows:
 │   └── sql                                     .sql files to create or upgrade DolphinScheduler metadata
 │  
 ├── worker-server                               directory of DolphinScheduler worker-server commands, configurations scripts and libs
-│       ├── bin
-│       │   └── start.sh                        script to start DolphinScheduler worker-server
-│       ├── conf
-│       │   ├── application.yaml                configurations of worker-server
-│       │   ├── bootstrap.yaml                  configurations for Spring Cloud bootstrap, mostly you don't need to modify this,
-│       │   ├── common.properties               configurations of common-service like storage, credentials, etc.
-│       │   ├── dolphinscheduler_env.sh         script to load environment variables for worker-server
-│       │   └── logback-spring.xml              configurations of worker-service log
-│       └── libs                                directory of worker-server libs
+│   ├── bin
+│   │   └── start.sh                        script to start DolphinScheduler worker-server
+│   │   └── jvm_args_env.sh                 script to set JVM args of DolphinScheduler worker-server
+│   ├── conf
+│   │   ├── application.yaml                configurations of worker-server
+│   │   ├── bootstrap.yaml                  configurations for Spring Cloud bootstrap, mostly you don't need to modify this,
+│   │   ├── common.properties               configurations of common-service like storage, credentials, etc.
+│   │   ├── dolphinscheduler_env.sh         script to load environment variables for worker-server
+│   │   └── logback-spring.xml              configurations of worker-service log
+│         └── libs                                directory of worker-server libs

Review Comment:
   Done



##########
docs/docs/zh/architecture/configuration.md:
##########
@@ -83,16 +88,18 @@ DolphinScheduler的目录结构如下:
 │   ├── libs                                    元数据工具依赖jar包存放目录
 │   └── sql                                     DolphinScheduler元数据创建/升级sql文件
 │  
+|
 ├── worker-server                               DolphinScheduler worker-server命令、配置和依赖存放目录
-│       ├── bin
-│       │   └── start.sh                        DolphinScheduler worker-server启动脚本
-│       ├── conf
-│       │   ├── application.yaml                worker-server配置文件
-│       │   ├── bootstrap.yaml                  Spring Cloud 启动阶段配置文件, 通常不需要修改
-│       │   ├── common.properties               公共服务(存储等信息)配置文件
-│       │   ├── dolphinscheduler_env.sh         worker-server环境变量配置加载脚本
-│       │   └── logback-spring.xml              worker-service日志配置文件
-│       └── libs                                worker-server依赖jar包存放目录
+│   ├── bin
+│   │   └── start.sh                        DolphinScheduler worker-server 启动脚本
+│   │   └── jvm_args_env.sh                 DolphinScheduler worker-server jvm参数配置脚本
+│   ├── conf
+│   │   ├── application.yaml                worker-server配置文件
+│   │   ├── bootstrap.yaml                  Spring Cloud 启动阶段配置文件, 通常不需要修改
+│   │   ├── common.properties               公共服务(存储等信息)配置文件
+│   │   ├── dolphinscheduler_env.sh         worker-server环境变量配置加载脚本
+│   │   └── logback-spring.xml              worker-service日志配置文件
+│         └── libs                                worker-server依赖jar包存放目录

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org