[GitHub] [activemq-artemis] gtully commented on a diff in pull request #4552: ARTEMIS-4362 Produce log.warn when the system cannot depage because of pending acks

["gtully (via GitHub)" <gi...@apache.org>]

gtully commented on code in PR #4552:
URL: https://github.com/apache/activemq-artemis/pull/4552#discussion_r1262307684


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##########
@@ -1584,4 +1584,7 @@ void slowConsumerDetected(String sessionID,
 
    @LogMessage(id = 224126, value = "Failure during protocol handshake on connection to {} from {}", level = LogMessage.Level.ERROR)
    void failureDuringProtocolHandshake(SocketAddress localAddress, SocketAddress remoteAddress, Throwable e);
+
+   @LogMessage(id = 224127, value = "Queue {}/Address {} is currently delivering {} messages that are holding {} bytes, with max reading sizes configured as addressSettings.maxPageReadMessages={} and addressSettings.maxPageReadBytes={}. System will not read more data from paging until acks are made. You can increase the address settings page-max-read attributes or make sure your consumers use lower batch sizes.", level = LogMessage.Level.WARN)

Review Comment:
   thinking of the event:
   dispatch is blocked, then the reason and what to do about it. so reorder the message a little.
   
   possibly:
   dispatch blocked. Address|Queue will not read more data from paging until dispatched|inflight|delivered messages are acked. X is currently delivering..... You can ...... etc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org