You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/15 22:47:44 UTC

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

cmccabe commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023331930


##########
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##########
@@ -91,7 +91,8 @@ object AlterPartitionManager {
       config = config,
       channelName = "alterPartition",
       threadNamePrefix = threadNamePrefix,
-      retryTimeoutMs = Long.MaxValue
+      networkClientRetryTimeoutMs = if (config.processRoles.isEmpty) config.controllerSocketTimeoutMs else config.brokerSessionTimeoutMs / 2,

Review Comment:
   we don't want to change this, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org