You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2014/11/27 16:15:41 UTC
[GitHub] cordova-plugin-file pull request: CB-8092 Adds support for encoded...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/94
CB-8092 Adds support for encoded URIs to windows platform
Fix for [CB-8092](https://issues.apache.org/jira/browse/CB-8092)
* Adds `filesystem._format_()` method for windows which is common place to handle URI encoding.
* Adds encoded URIs support to windows FileProxy methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-8092
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/94.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #94
----
commit a848f7d849146ab72d4cba45c958b99fbfb06271
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2014-11-27T15:11:05Z
CB-8092 Adds support for encoded URIs to windows platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8092 Adds support for encoded...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/94#issuecomment-64819400
https://github.com/apache/cordova-plugin-file/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8092 Adds support for encoded...
Posted by ferryfax <gi...@git.apache.org>.
Github user ferryfax commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/94#issuecomment-77104836
Ok will do. In fact looking at it some more the culprit seems to be File-Transfer that is calling resolveLocalFileSystemURI with a mix of \ and / in the URI. Not sure if File-transfer should be fixed or if resolveLocalFileSystemURI should handle it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8092 Adds support for encoded...
Posted by vldmrrr <gi...@git.apache.org>.
Github user vldmrrr commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/94#issuecomment-64818316
Hmm, looks like that PR's for windows file plugin keeps coming with incremental changes proposed to current code base. I just wanted to bring to everyones attention that there is an earlier PR CB-7883 with associated pull request, that actually make the plugin on windows pass all current crossplatform tests, and also makes it easy to plug additional file systems, similar to other platforms - one of them, root (file:///) is already included. Maybe it would be worth reviewing that code before taking divergent path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8092 Adds support for encoded...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/94#issuecomment-77102704
@ferryfax Probably [Apache JIRA](https://issues.apache.org/jira/browse) is the best place for reporting such issues. Could you please also post a short snippet of code to repro the problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8092 Adds support for encoded...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8092 Adds support for encoded...
Posted by ferryfax <gi...@git.apache.org>.
Github user ferryfax commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/94#issuecomment-77101334
Don't know if this is the right place to comment on this but when I tried to use the latest File plugin I was getting an exception because the validName check in resolveLocalFileSystemURI was failing. The path returned from pathFromURL(uri) had a \ in it so I needed to clean it up first with nativePathToCordova.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org