You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/02 19:21:43 UTC

[GitHub] [geode] jinmeiliao opened a new pull request, #7639: GEODE-9390: Guarding membership addition code paths to omit membership duplicates

jinmeiliao opened a new pull request, #7639:
URL: https://github.com/apache/geode/pull/7639

   This is a continuation of PR #7554: https://github.com/apache/geode/pull/7554


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jinmeiliao merged pull request #7639: GEODE-9390: Guarding membership addition code paths to omit membership duplicates

Posted by GitBox <gi...@apache.org>.
jinmeiliao merged PR #7639:
URL: https://github.com/apache/geode/pull/7639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jchen21 commented on a diff in pull request #7639: GEODE-9390: Guarding membership addition code paths to omit membership duplicates

Posted by GitBox <gi...@apache.org>.
jchen21 commented on code in PR #7639:
URL: https://github.com/apache/geode/pull/7639#discussion_r864047176


##########
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java:
##########
@@ -1867,6 +1877,12 @@ void shutdownMessageReceived(InternalDistributedMember theId, String reason) {
     handleManagerDeparture(theId, false, reason);
   }
 
+  long getNonLocatorViewMembers() {
+    return getViewMembers().stream()

Review Comment:
   I think instead of `getViewMembers()`, it is better to use `distribution.getMembersNotShuttingDown()` to exclude the members that are shutting down. Please see `getOtherDistributionManagerIds()` and `getOtherNormalDistributionManagerIds()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jinmeiliao commented on a diff in pull request #7639: GEODE-9390: Guarding membership addition code paths to omit membership duplicates

Posted by GitBox <gi...@apache.org>.
jinmeiliao commented on code in PR #7639:
URL: https://github.com/apache/geode/pull/7639#discussion_r865293177


##########
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java:
##########
@@ -1867,6 +1877,12 @@ void shutdownMessageReceived(InternalDistributedMember theId, String reason) {
     handleManagerDeparture(theId, false, reason);
   }
 
+  long getNonLocatorViewMembers() {
+    return getViewMembers().stream()

Review Comment:
   thanks for pointing out those methods. updated the PR to use that instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org