You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/05/14 06:41:23 UTC
[GitHub] [carbondata] qiuchenjian commented on a change in pull request
#3150: [CARBONDATA-3309] MV datamap supports Spark 2.1
qiuchenjian commented on a change in pull request #3150: [CARBONDATA-3309] MV datamap supports Spark 2.1
URL: https://github.com/apache/carbondata/pull/3150#discussion_r283644949
##########
File path: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/AggregatePushDown.scala
##########
@@ -106,12 +106,14 @@ trait AggregatePushDown { // self: ModularPlan =>
} else {
Map.empty[Int, (NamedExpression, Seq[NamedExpression])]
}
- case sum@AggregateExpression(Sum(Cast(expr, dataType, timeZoneId)), _, false, _)
- if expr.isInstanceOf[Attribute] =>
- val tAttr = selAliasMap.get(expr.asInstanceOf[Attribute]).getOrElse(expr)
+ case sum@AggregateExpression(Sum(child), _, false, _)
Review comment:
This code use Cast with timeZoneId, But CarbonExpressions.MatchCast didn't have timeZoneId
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services