[GitHub] joshelser commented on a change in pull request #868: Make replication services start when configured

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #868: Make replication services start when configured
URL: https://github.com/apache/accumulo/pull/868#discussion_r245130252
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -456,6 +456,8 @@
       "The amount of time an assignment can run before the server will print a"
           + " warning along with the current stack trace. Meant to help debug stuck"
           + " assignments"),
+  TSERV_REPLICATION_ENABLED("tserver.replication.services.enabled", "false", PropertyType.BOOLEAN,
 
 Review comment:
   > the current design doesn't make a single replication.enabled option as simple to do as it first appears.
   
   I'm not sure what you think is untenable here. There are multiple services that are started, in different processes, but it all uses the single configuration option: a global on/off.
   
   > It should be entirely possible to enable these features independently (to support basically any use case that isn't bi-directional replication between two Accumulo instances).
   
   The current implementation is definitely not intended to be used in this fashion. I'd caution against trying to separate these as it's going to open a can of worms. If nothing else, if this is an itch you want to scratch, do that on its own to avoid conflating these issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services