You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/12/28 16:43:04 UTC
[PR] chore: Try to fix Netty leak with explicit read. [pekko]
He-Pin opened a new pull request, #1638:
URL: https://github.com/apache/pekko/pull/1638
Motivation:
refs: https://github.com/apache/pekko/issues/1634
Modification:
Do explicit read instead.
Result:
Expect No leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1638:
URL: https://github.com/apache/pekko/pull/1638#issuecomment-2564386850
Do local run with `cluster/MultiJvm/test` and ` -Dio.netty.leakDetection.level=PARANOID` to find if it leaked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #1638: chore: Try to fix Netty leak with explicit read.
URL: https://github.com/apache/pekko/pull/1638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]
Posted by "jxnu-liguobin (via GitHub)" <gi...@apache.org>.
jxnu-liguobin commented on code in PR #1638:
URL: https://github.com/apache/pekko/pull/1638#discussion_r1898957082
##########
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala:
##########
@@ -36,7 +35,7 @@ private[netty] trait NettyHelpers {
protected def onOpen(@unused ctx: ChannelHandlerContext): Unit = ()
- protected def onMessage(@unused ctx: ChannelHandlerContext, @unused msg: ByteBuf): Unit = ()
+ protected def onMessage(@unused ctx: ChannelHandlerContext, @unused msg: Array[Byte]): Unit = ()
Review Comment:
Is there anything special about ByteBuf ? (;I don't know about Netty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1638:
URL: https://github.com/apache/pekko/pull/1638#issuecomment-2564397150
This should not be needed, the current code is right, thanks god :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Try to fix Netty leak with explicit read. [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1638:
URL: https://github.com/apache/pekko/pull/1638#discussion_r1898957180
##########
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyHelpers.scala:
##########
@@ -36,7 +35,7 @@ private[netty] trait NettyHelpers {
protected def onOpen(@unused ctx: ChannelHandlerContext): Unit = ()
- protected def onMessage(@unused ctx: ChannelHandlerContext, @unused msg: ByteBuf): Unit = ()
+ protected def onMessage(@unused ctx: ChannelHandlerContext, @unused msg: Array[Byte]): Unit = ()
Review Comment:
This PR is just a Try, and will not be needed. the old code is actually right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org