[GitHub] [nifi] thenatog commented on a change in pull request #4670: NIFI-7673 Standalone diagnosis mode verifies independent node

[GitBox <gi...@apache.org>]

thenatog commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r526497429



##########
File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/CertificateUtils.java
##########
@@ -120,12 +123,29 @@
         return Collections.unmodifiableMap(orderMap);
     }
 
+    private static Map<Integer, String> createSANOrderMap() {
+        Map<Integer, String> orderMap = new HashMap<>();
+        int count = 0;
+        orderMap.put(count++, "otherName");
+        orderMap.put(count++, "rfc822Name");
+        orderMap.put(count++, "dNSName");
+        orderMap.put(count++, "x400Address");
+        orderMap.put(count++, "directoryName");
+        orderMap.put(count++, "ediPartyName");
+        orderMap.put(count++, "uniformResourceIdentifier");
+        orderMap.put(count++, "iPAddress");
+        orderMap.put(count, "registeredID");
+        return Collections.unmodifiableMap(orderMap);

Review comment:
       It would have been ideal to use GeneralName here but the ASN1 classes seem pretty unintuitive. I couldn't figure out a great way to employ it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org