You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Ted Husted (JIRA)" <ji...@apache.org> on 2006/11/21 03:48:57 UTC

[jira] Created: (WW-1517) Streamlined link tag for single-parameter links

Streamlined link tag for single-parameter links
-----------------------------------------------

                 Key: WW-1517
                 URL: http://issues.apache.org/struts/browse/WW-1517
             Project: Struts 2
          Issue Type: New Feature
          Components: Views
            Reporter: Ted Husted
             Fix For: 2.0.2


The url and param tags are very flexibile, but the most common case of a single parameter link. 

        <s:url id="url" action="HelloWorld" includeContext="false">
            <s:param name="request_locale">en</s:param>
        </s:url>
        <s:a href="%{url}">English</s:a>

is verbose (to the point of being silly).

It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.

        <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>

In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Joe Germuska (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39802 ] 

Joe Germuska commented on WW-1517:
----------------------------------

Earlier, I asked:
     Are there any extant tags which hold on to an additional Component instance besides their "primary one"? 

I'm still getting familiar with the architecture of the component tags, but it kind of seems to me that it will be pretty hacky to use two components.  If I want to extend AnchorTag but also have a URL component then I kind of need to construct the URL object in getBean(stack,req,res).  I can do this, but it seems like a "side effect" to requesting the bean.  And if I'm not returning the URL object, then I also need to replicate the dependency injection behavior for the URL which is done for the "primary" component bean in doStartTag() after getBean is called.

I am not saying I think it would be horrible to do this, but it's not that elegant either, so especially because i'm new to the tag architecture, I didn't want to act without input.

Also, since I can only extend one tag, I would have to duplicate the "populateParameters()" behavior from URLTag to initialize my URL component.  Would it be crazy to have component beans have a populateParameters(Object source) method?  I am not sure I love that, but it crossed my mind as one possible solution.

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>             Fix For: 2.0.x
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Husted updated WW-1517:
---------------------------

         Priority: Critical  (was: Major)
    Fix Version/s:     (was: 2.0.x)
                   2.0.5

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>            Priority: Critical
>             Fix For: 2.0.5
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Dave Newton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39949 ] 

Dave Newton commented on WW-1517:
---------------------------------

Including the paramMap functionality could really clean up JSP code if the map can be built in the Action, although it might be nice if you could still add params via the s:param tag.

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>            Priority: Critical
>             Fix For: 2.0.5
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/WW-1517?page=all ]

Ted Husted updated WW-1517:
---------------------------

    Fix Version/s: 2.0.x
                       (was: Future)

Tagging features we could implement in the near term. 

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: http://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>             Fix For: 2.0.x
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Joe Germuska (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Germuska reassigned WW-1517:
--------------------------------

    Assignee: Joe Germuska

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>             Fix For: 2.0.x
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-1517:
--------------------------

    Fix Version/s:     (was: 2.0.8)
                   2.1.0

Moving to 2.1.0 as it is a new feature

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>            Priority: Critical
>             Fix For: 2.1.0
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39798 ] 

Ted Husted commented on WW-1517:
--------------------------------

At one point, includeContext was stacking up the the parameters if used in a get, so the query string just got longer and longer if the link lead back to the same page. But, that behavior changed between 2.0.2 and 2.0.3, and so true would be fine now. 





> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>             Fix For: 2.0.x
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-1517:
--------------------------

         Priority: Major  (was: Critical)
    Fix Version/s:     (was: 2.1.3)
                   Future

Seems important, but with no one signing up to do the work, I'm moving it to future.

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Plugin - Tags
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>            Assignee: Joe Germuska
>             Fix For: Future
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Joe Germuska (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39797 ] 

Joe Germuska commented on WW-1517:
----------------------------------

OK, I'm willing to take a crack at this but it seems worthy of some discussion.  It seems that the end goal is a "fusion" of the AnchorTag and the URLTag. 

 My plan is to extend AnchorTag and copy its TLD so as to continue to support all of its attributes.  Then, as Ted suggested, add

param
paramValue

(I'd consider also having something like paramMap as an alternative, if people thought it was a good idea, but if no one argues for it, I'd probably leave it out for now.)

the URL tag has the following attributes:

    protected String includeParams;
    protected String scheme;
    protected String value;
    protected String action;
    protected String namespace;
    protected String method;
    protected String encode;
    protected String includeContext;
    protected String portletMode;
    protected String windowState;
    protected String portletUrlType;
    protected String anchor;
Obviously we need to support "action" and "value"  or we haven't achieved anything.  The main reason I want to use it is to have the "includeContext" behavior that the url tag gives -- so I dont think I understand why Ted wants it to be false?

Should we drag all of these across?

Are there any extant tags which hold on to an additional Component instance besides their "primary one"?

Any other things to think about?

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>             Fix For: 2.0.x
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39961 ] 

Ted Husted commented on WW-1517:
--------------------------------

All too often, the only way to get anyone to comment on anything is to commit something :) 

Sometimes, a "dodgy" commit is better than none, since then people have something concrete to discuss. 


> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>            Priority: Critical
>             Fix For: 2.0.5
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Joe Germuska (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39950 ] 

Joe Germuska commented on WW-1517:
----------------------------------

Ted recently upgraded this one to "critical" and slated it for the next release.

If I'm going to keep it assigned to me,  I'd really appreciate at least a little opinion from someone with more investment in the UI tag architecture on the questions noted above....

anyone? 

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: https://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>         Assigned To: Joe Germuska
>            Priority: Critical
>             Fix For: 2.0.5
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/WW-1517?page=all ]

Ted Husted updated WW-1517:
---------------------------

    Description: 
The url and param tags are very flexibile, but the most common case of a single parameter link. 

        <s:url id="url" action="HelloWorld" includeContext="false">
            <s:param name="request_locale">en</s:param>
        </s:url>
        <s:a href="%{url}">English</s:a>

is verbose (to the point of being silly).

It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.

        <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>

In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 

Or, with a message resource key, from

<a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>

to 

 <s:link action="login_input" key="sign_on" />



  was:
The url and param tags are very flexibile, but the most common case of a single parameter link. 

        <s:url id="url" action="HelloWorld" includeContext="false">
            <s:param name="request_locale">en</s:param>
        </s:url>
        <s:a href="%{url}">English</s:a>

is verbose (to the point of being silly).

It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.

        <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>

In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 





> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: http://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>            Reporter: Ted Husted
>             Fix For: 2.0.2
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WW-1517) Streamlined link tag for single-parameter links

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/WW-1517?page=all ]

Don Brown updated WW-1517:
--------------------------

        Fix Version/s: Future
                           (was: 2.0.2)
    Affects Version/s: 2.0.1

I like the feature, but moving to Future until someone signs up to implement it

> Streamlined link tag for single-parameter links
> -----------------------------------------------
>
>                 Key: WW-1517
>                 URL: http://issues.apache.org/struts/browse/WW-1517
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Ted Husted
>             Fix For: Future
>
>
> The url and param tags are very flexibile, but the most common case of a single parameter link. 
>         <s:url id="url" action="HelloWorld" includeContext="false">
>             <s:param name="request_locale">en</s:param>
>         </s:url>
>         <s:a href="%{url}">English</s:a>
> is verbose (to the point of being silly).
> It is worthwhile to have a streamlined link tag, a al Struts 1, to cover the single-parameter case.
>         <s:link action="HelloWorld" param="request_locale" paramValue="en">English</s:link>
> In the interest of brevity, I would suggest that includeContext default to "false" for the single-parameter case. 
> Or, with a message resource key, from
> <a href="<s:url action="Login_input"/>">%{getText('"sign_on"')}</a>
> to 
>  <s:link action="login_input" key="sign_on" />

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira