You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "JacobZheng0927 (via GitHub)" <gi...@apache.org> on 2026/07/10 06:32:17 UTC
[PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
JacobZheng0927 opened a new pull request, #11396:
URL: https://github.com/apache/seatunnel/pull/11396
### Purpose of this pull request
Fixes #6916.
The JDBC fixed chunk splitter converted `DATE` partition bounds to numeric values and later bound those values as `BigDecimal`. JDBC drivers either reject that conversion or compare the `DATE` column with a numeric parameter incorrectly, which can make every generated split return zero rows.
This patch performs `DATE` range arithmetic in epoch days and converts generated split boundaries back to `java.sql.Date` before binding them. Numeric partition columns keep the existing `BigDecimal` behavior.
Unlike the closed approach in #6917, this change does not convert every integral `BigDecimal` parameter to a timestamp, so numeric partition columns are unaffected.
### Does this PR introduce _any_ user-facing change?
Yes. JDBC source fixed splitting now binds `DATE` partition boundaries with `PreparedStatement#setDate`, allowing `DATE` partition columns to return the expected rows.
### How was this patch tested?
Added unit coverage for generated `DATE` split boundaries and JDBC parameter binding.
```shell
./mvnw -pl seatunnel-connectors-v2/connector-jdbc \
-DfailIfNoTests=false \
-Dtest=FixedChunkSplitterTest test
```
Result: 6 tests run, 0 failures, 0 errors, 0 skipped.
### Check list
* [x] No new Jar binary package is added.
* [x] No documentation update is required; this fixes existing documented `DATE` partition-column support.
* [x] No incompatible change is introduced.
* [x] No new connector is added, so plugin mapping, distribution POM, labels, plugin config, and new-connector E2E updates are not applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-6338088500
A CI-status correction on unchanged head `6e73c0e64b81d7d88f83da06834728b6939c47d9`: my previous note described a queued/pending Build. The current [Build](https://github.com/apache/seatunnel/runs/118514186374) is now **failure**, so the old pending guidance is obsolete. Failed job families: `Run / unit-test`, `Run / edge-agent-it`.
Concrete inspected log evidence (one representative JDK/OS per failed family; this does not claim every matrix leg has the identical cause):
- [Run / unit-test (11, ubuntu-latest)](https://github.com/JacobZheng0927/seatunnel/actions/runs/39385115016/job/118504894431): `LLMBooleanOutputTest.readsLegacyFactoryWrapperWithValidationDisabled` fails with `InvalidClassException` on `AbstractMultiCatalogTransform`.
- [Run / edge-agent-it (11, ubuntu-latest)](https://github.com/JacobZheng0927/seatunnel/actions/runs/39385115016/job/118504895115): `LLMBooleanOutputTest.readsLegacyFactoryWrapperWithValidationDisabled` fails with `InvalidClassException` on `AbstractMultiCatalogTransform`.
Upstream/next-step check:
The archived LLM fixture is tracked in #12929; proposed fix #12938 remains open. Latest `dev` (`99ea16b9d6bdce452d4c4955581ccc7236a81bbd`) still has no explicit historical UID on `AbstractMultiCatalogTransform`. Syncing today will not fix that observed failure. Once the fix lands in `dev`, sync and rerun the affected failed jobs. Keep unrelated transform-serialization changes out of this PR.
My earlier source/test/documentation blockers remain in force; these CI facts do not clear them. Please follow the existing numbered findings before requesting a new full review. The branch is ahead 5, behind 10, compare `diverged` against `dev`; this drift is recorded independently, not used as a generic sync request. A successful required Build and write-capable maintainer approval remain merge gates. Thanks for the contribution and for keeping the fix focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "davidzollo (via GitHub) via commits" <co...@seatunnel.apache.org>.
davidzollo merged PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-5340998103
Checking in on the CI signal here since it looks like it flipped state. On this unchanged head (`9dd184d69e7c`), the `Build` check is currently showing `ACTION_REQUIRED` again (https://github.com/apache/seatunnel/runs/86301794072), rather than the `FAILURE` I recorded on July 14. This state usually means the workflow run needs a maintainer to approve/retrigger it before it can actually execute, so it is not something resolvable from the fork side alone.
From Daniel's source-review side there is still no reopened code blocker on this head. Once a maintainer approves the pending workflow run and it completes, I'll take another look at the real result.
@davidzollo (or another maintainer with the right permissions) — could someone approve the pending workflow run when convenient so this can move forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-4937412068
Good job.
Thanks a lot for your valuable contribution to Apache SeaTunnel!
From Daniel's source-review side, I do not see a new code-side blocker on the current head. The current remaining gate is that the PR workflow is still `action_required`, so could you please enable CI workflows in your forked repository first? You can use this check link as the exact reference for the workflow that needs to be enabled:
https://github.com/apache/seatunnel/runs/86301794072
If you run into any trouble enabling CI or hit a follow-up workflow error after that, feel free to leave a comment here. Happy to take another look once the checks are running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-5192177503
Thanks for your contribution! This is a solid addition to the project, and your attention to detail really shows. Contributors like you are what keep this community moving forward. Feel free to keep the PRs coming — we're always glad to have you here!
Please ignore the following message if you have joined in the Slack~
```
To facilitate focused communication among contributors, we’ve created a brand-new dedicated #contributors channel in official Slack workspace.
Slack workspace link: https://s.apache.org/seatunnel-slack
This channel is designed for technical discussions, feature design brainstorming, roadmap sync and direct communication with project core Contributors. Everyone who contributes code, docs, test cases or community ideas is warmly invited to join, share thoughts and collaborate together under The Apache Way. Welcome to join 😄
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "dybyte (via GitHub)" <gi...@apache.org>.
dybyte commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-4937285391
Please enable CI following [the instruction](https://github.com/apache/seatunnel/pull/11396/checks?check_run_id=86301794072)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-6285509664
Pushed merge commit `6e73c0e64b8` (current `dev` into your branch), @JacobZheng0927. No conflicts and the PR's own files are unchanged by the merge; the goal is a fresh CI run, since the last `Build` result (fork run 32680436515 from 2026-08-24) only failed on the Doris testcontainer port timeouts I described earlier, which are unrelated to `FixedChunkSplitter`.
Your fork did not create a Build run for this push; if none appears, please start one from the Actions tab ("Run workflow" on Build). I started a verification run of the same head on my fork: https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11396-verify-6e73c0e64b8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "nzw921rx (via GitHub)" <gi...@apache.org>.
nzw921rx commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-6460730876
please resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-5459248548
Updating the CI status from my last review, where I noted the `Build` check on this exact commit (`31b49e6b7`) was "currently queued on the fork... nothing to diagnose yet." That run (`32680436515`) has since completed with `failure`, so there's now something concrete to report.
I pulled the job logs rather than just reading the check name: the failures are five Doris E2E test classes (`DorisTimerFlushIT`, `DorisCDCSinkIT`, `DorisErrorIT`, `DorisCatalogIT`, `DorisMultiReadIT`), and every one of them fails the same way -- `org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open` while starting the `apache/doris:doris-all-in-one-2.1.0` testcontainer (one even failed one step earlier, on the image pull itself, with an `InterruptedException`). That's a container/runner-resource bootstrap issue in the Doris connector-it module, not a test assertion failure, and it has nothing to do with this PR's diff (`FixedChunkSplitter` / JDBC partition-column splitting) -- the Doris connector code path isn't touched here.
From my source-review side there's still no open code blocker on this head. Given the failure signature looks like transient container/runner contention rather than a deterministic break, the lowest-cost next step is a plain rerun of the failed jobs; if it reproduces identically on a clean rerun, that would point to something more systemic on the runner side worth a separate look, but I wouldn't hold this PR on it either way since the failing module is outside this diff's blast radius.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "JacobZheng0927 (via GitHub)" <gi...@apache.org>.
JacobZheng0927 commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-5389737626
Addressed the remaining review item in commit 31b49e6b7.
Malformed non-numeric bounds for DATE, TIME, TIMESTAMP, and TIMESTAMP_TZ are now wrapped in JdbcConnectorException with type-appropriate messages, and a TIMESTAMP regression test was added.
The new Build check is pending; please take another look once CI completes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-5149755699
Thanks for your contribution for Apache SeaTunnel.
To facilitate focused communication among contributors, we’ve created a brand-new dedicated #contributors channel in official Slack workspace.
Slack workspace link: https://s.apache.org/seatunnel-slack
This channel is designed for technical discussions, feature design brainstorming, roadmap sync and direct communication with project core Contributors. Everyone who contributes code, docs, test cases or community ideas is warmly invited to join, share thoughts and collaborate together under The Apache Way. Welcome to join us😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-4968431055
Rechecked the current head `9dd184d69e7c` against the latest `dev` after the CI / merge-gate fact changed.
## Runtime path rechecked
```text
same runtime path as the previous Daniel review on this unchanged head
```
## Merge conclusion
### Conclusion: source blocker cleared from Daniel's side; sync latest `dev` and rerun CI first
1. Blocking items
- None reopened from Daniel's source review on this unchanged head.
- This branch is behind upstream (`compare status: diverged`, `ahead_by=1`, `behind_by=11`), and the current failing gate is `FAILURE gate: Build`: https://github.com/apache/seatunnel/runs/86301794072
2. Lowest-cost next step
- Please sync with the latest `dev` and rerun the failing gate first.
- If it still fails on the updated head, I can help narrow down the new failure from there.
Daniel only has `READ` permission on this repository, so a write-capable maintainer may still need to handle the final approval / dismissal step once the gate is clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-5149757571
Thanks for your contribution for Apache SeaTunnel.
To facilitate focused communication among contributors, we’ve created a brand-new dedicated #contributors channel in official Slack workspace.
Slack workspace link: https://s.apache.org/seatunnel-slack
This channel is designed for technical discussions, feature design brainstorming, roadmap sync and direct communication with project core Contributors. Everyone who contributes code, docs, test cases or community ideas is warmly invited to join, share thoughts and collaborate together under The Apache Way. Welcome to join us😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-6339513903
Thanks for your patience. The upstream status has changed since my preceding note: [#12938](https://github.com/apache/seatunnel/pull/12938) merged into `dev` at 2026-10-22 10:26 UTC (merge `cc54bb433357b4cb45db9cd5d0743589c3111b79`). I checked that current dev contains the merge and that its diff restores the historical `AbstractMultiCatalogTransform` serialization UID and makes the construction-only config transient. My earlier instruction to wait for that fix is now superseded.
The archived-wrapper `LLMBooleanOutputTest.readsLegacyFactoryWrapperWithValidationDisabled` / `InvalidClassException` is the shared unit-test failure identified in the preceding review ([affected job](https://github.com/JacobZheng0927/seatunnel/actions/runs/39385115016/job/118504894431)). This head is still `6e73c0e64b81d7d88f83da06834728b6939c47d9`; the current `dev` comparison is `diverged`, ahead 5 / behind 12. Please sync with the latest `dev` and rerun the affected unit checks first, plus any stage whose log showed the same archived-wrapper error. Keep unrelated transform-serialization patches out of this PR. This is a targeted remedy for that known upstream failure, not a claim that syncing fixes every failed stage.
Other failed job families in the same head's run are `edge-agent-it`. Their causes/results remain separate; this upstream patch does not establish that they pass. The existing source/documentation blockers in my preceding review remain open; the upstream CI correction clears none of those findings. Required CI and the final write-capable maintainer review remain gates. This is a CI-status follow-up only, with no new source findings or fresh full-review claim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2][Jdbc] Fix DATE partition column splitting [seatunnel]
Posted by "JacobZheng0927 (via GitHub)" <gi...@apache.org>.
JacobZheng0927 commented on PR #11396:
URL: https://github.com/apache/seatunnel/pull/11396#issuecomment-5368447971
Thanks for the detailed review.
I addressed the requested items in the previous fix commit and applied the Spotless formatting corrections reported by CI in commit eb5195ae1:
- Added clear validation for malformed and fractional temporal partition bounds.
- Added coverage for DATE, TIME, TIMESTAMP, TIMESTAMP_TZ, fallback parsing, and invalid inputs.
- Added the requested comments and updated the English and Chinese JDBC documentation.
The previous Build run failed only because of the reported formatting violations; no code or test failure was reported. A new CI run is now pending. Could you please take another look once CI completes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org