You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/09 14:47:29 UTC

[GitHub] [skywalking] wu-sheng edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm

wu-sheng edited a comment on pull request #5274:
URL: https://github.com/apache/skywalking/pull/5274#issuecomment-671060825


   My point is, there is no need for config. You could use `class#forName` to determine whether this is IBM/SUN JDK or others.
   
   The open-source community is welcome and looking forward to the feedback, but also, at the same time, the high quality of open source project is based on the review mechanism and making the codes as best as you can. 
   
   I could understand your point of how to make this works, but I also hope you could understand, open-source work is a kind of collaboration. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org