[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2491: [KYUUBI #2309][SUB-TASK][KPIP-4] Implement BatchesResource POST /batches

[GitBox <gi...@apache.org>]

turboFei commented on code in PR #2491:
URL: https://github.com/apache/incubator-kyuubi/pull/2491#discussion_r861428308


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -103,6 +103,19 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
     }
   }
 
+  def getUserName(req: BatchRequest): String = {
+    val realUser: String = ServiceUtils.getShortName(
+      Option(AuthenticationFilter.getUserName).filter(_.nonEmpty).getOrElse("anonymous"))
+    if (req.proxyUser == null) {

Review Comment:
   sounds good



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org