[GitHub] [incubator-nuttx] yamt commented on pull request #5365: Revert "sim: add CONFIG_SIM_STACKSIZE_ADJUSTMENT to reduce variability"

[GitBox <gi...@apache.org>]

yamt commented on pull request #5365:
URL: https://github.com/apache/incubator-nuttx/pull/5365#issuecomment-1023925560


   > > ## Summary
   > > This reverts commit [6b5a7a7](https://github.com/apache/incubator-nuttx/commit/6b5a7a73ba76671c81dc70485befb5ed5e818fe0).
   > > Because:
   > > 
   > > * it broke existing configurations.
   > 
   > could you point out which config broken?
   
   eg. my local config, which is now using much larger stack than intended.
   
   > 
   > > * it makes stack-related api very confusing.
   > >   eg. the "stack_size" argument of nxtask_init has different meanings
   > >   depending on "stack".
   > 
   > If you don't like the stack size reported from ps, I can change the report size as user passed one, but allocate the bigger memory.
   
   i was not talking about the report size.
   
   nxtast_init takes "non adjusted" stack_size for stack==NULL
   while it takes "adjusted" stack_size for stack!=NULL.
   
   > 
   > > eg. pthread_attr_setstack and pthread_attr_setstacksize
   > > 
   > > * stacksize is inherently arch-dependent.
   > 
   > Yes, that's why the adjust is located in arch/sim.
   > 
   > > the goal to share the same stack size configurations among archs
   > > is questionable.
   > 
   > As I explain before no one try to the same stack config for all arch, I just want to fix sim problem.
   
   ok.
   maybe "the goal to share the same stack size configurations between arch X and sim is questionable" is a better description?
   
   > 
   > > ## Impact
   > > sim
   > > ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org