You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/28 22:49:40 UTC
[GitHub] [netbeans] oyarzun opened a new pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
oyarzun opened a new pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717
Update macOS Native Launchers to call the unix launcher shell scripts instead of duplicating the logic in the scripts.
As @neilcsmith-net pointed out in https://github.com/apache/netbeans/pull/2563#issuecomment-765627457 this will avoid having to update the logic in yet another place as we do with the Windows Launcher.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] oyarzun commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
oyarzun commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-785133031
> In the original PR you mentioned using Apple APIs to look up userdir and cache locations. Are the values in the script always correct? If not, another use for environment variables?
The values in the script are correct, so there is no need to add it to the binary.
```shell
# set default userdir and cachedir on Mac OS X
DEFAULT_USERDIR_ROOT="${HOME}/Library/Application Support/${APPNAME}"
DEFAULT_CACHEDIR_ROOT=${HOME}/Library/Caches/${APPNAME}
```
> This looks a good change to me, and I like passing in the dock name as an environment variable. That actually covers one use I've had in platform apps for forking the launch script.
What are your other changes to the launch script? Anything that should be added to the binary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-785148280
Thanks @oyarzun
> The values in the script are correct, so there is no need to add it to the binary.
Good to know.
> What are your other changes to the launch script? Anything that should be added to the binary?
Nothing usefully generic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] oyarzun commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
oyarzun commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-797492695
@mcdonnell-john when you get a chance can you review this PR to see if can be merged into master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] oyarzun commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
oyarzun commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-805026449
@neilcsmith-net it will need to be addressed in this PR since the Swift 5 runtime is need to macOS prior to 10.14.4. We can add some checks in the installer logic to check if it needs to be installed.
https://support.apple.com/kb/dl1998?locale=en_US
I imagine we can not package the runtime due to potential license issues? Would the installer have to download the runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] oyarzun commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
oyarzun commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-805050752
IMHO, the easiest would be to add a link on the webpage and note that macOS < 10.14.4 requires the user to download the Swift 5 runtime library. But adding it in the installer would avoid those who don't read the note on the webpage.
I'm not familiar enough with the mac Package installers to know how easy it would be to add logic to use the script for earlier versions instead of the swift launcher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] oyarzun commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
oyarzun commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-811878040
@neilcsmith-net given the discussion on the [dev mailing list](https://lists.apache.org/thread.html/r099b047a8b9d7dc9b52c8b8d3e181aa641ead28b7cd6907b8267ab1e%40%3Cdev.netbeans.apache.org%3E) should we go ahead and merge this for 12.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-811913994
@oyarzun yes, let's do that before beta - cc @geertjanw
@mcdonnell-john we're going to vote on beta this time around. Once that's through, could we get a macOS installer with this for testing purposes? Probably good to widen the pool of people who know how to handle that process too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-769875393
Thanks @oyarzun To be clear, the duplication of logic is not the only concern I have. The Windows launcher is the same launcher used in the zip bundles, and thus daily builds, betas, etc. It's having two methods of launching on macOS, both requiring updates and testing, one of which more likely to be used by devs, one by users, and which we're not (at the moment) in a good position to test.
This looks a good change to me, and I like passing in the dock name as an environment variable. That actually covers one use I've had in platform apps for forking the launch script.
In the original PR you mentioned using Apple APIs to look up userdir and cache locations. Are the values in the script always correct? If not, another use for environment variables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-804990991
@oyarzun @mcdonnell-john in case you haven't noticed, can you check the issue at https://issues.apache.org/jira/browse/NETBEANS-5481 and see if there's a cause that needs addressing in this PR? Or is this a build issue locally for the installer? Something that could be fixed in an installer update for 12.3? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-804990991
@oyarzun @mcdonnell-john in case you haven't noticed, can you check the issue at https://issues.apache.org/jira/browse/NETBEANS-5481and see if there's a cause that needs addressing in this PR? Or is this a build issue locally for the installer? Something that could be fixed in an installer update for 12.3? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-805031516
Is there overlap between where Swift runtime is required and where NETBEANS-5004 requires to not use a shell script? Because if going as far as the installer checking macOS version, would it make sense to revert to the old shell script on < 10.14.4 rather than requiring an extra download? Just considering what might be easier here or for users. Somehow needs a fix for 12.4, and probably a description and link on the 12.3 download page?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mcdonnell-john commented on pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
mcdonnell-john commented on pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717#issuecomment-802284671
Hi @oyarzun, Yeah no problems, I'll have a look at the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #2717: [NETBEANS-5004] Update macOS native launchers to call launcher shell script rather than nbexec
Posted by GitBox <gi...@apache.org>.
geertjanw merged pull request #2717:
URL: https://github.com/apache/netbeans/pull/2717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists