[GitHub] jvrao commented on issue #347: Provide a zero-copy write protocol

[GitBox <gi...@apache.org>]

jvrao commented on issue #347: Provide a zero-copy write protocol
URL: https://github.com/apache/bookkeeper/issues/347#issuecomment-372912135
 
 
   Great discussion, but I am not sure where we are headed.
   
   1. What kind of improvements is possible with ProtoBufs?
   a. Move to V3 and use unsafe operations. As per @dlg99 this saves memory allocations but not buffer copy.
   b. As @dlg99  suggested we can implement splice, does anyone have a good grasp of what it can save? Do we approach near to zero-copy?
   c. Should we consider separating the payload as @ivankelly  suggested?
   
   2. With the combination of a/b/c can we live with Probuff v3 or should we seriously consider FlatBuffs?
   3. Even with FlatBuffs it is not a slamdunk and it's going to be a huge change. Is it really worth?
   
   We really need to improve this and I would love everyone to switch to V3 protocol. It's a small community, and having two protocols, neither will get enough testing/attention. This is clearly evident with the latest refcount bug(s) we ran into.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services