You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/29 12:03:46 UTC
[GitHub] [flink-statefun] tzulitai opened a new pull request #195: [FLINK-21171] Wire in TypedValue throughout the runtime as state values and message payloads
tzulitai opened a new pull request #195:
URL: https://github.com/apache/flink-statefun/pull/195
The end result of this PR is as follows:
- The `RequestReplyFunction` now fully works against `TypedValue`s, and not Protobuf `Any`s. This means that messages sent from functions to other functions as well as egresses, and state values, are now all `TypedValue`s.
- Messages sent from ingresses to functions via the text-based auto-routable Kafka / Kinesis ingresses, are also `TypedValue`s now.
- The Python SDK has been modified minimally to work with the new type system. This means that, at the API surface, nothing is changed and users still work with `Any`. To work with the new `TypedValue`s, at the very boundaries of the SDK we convert `TypedValuie` to / from `Any`. This is a temporary solution to minimize the changes in this PR, and will go away once we rework the Python SDK to work properly with the new type system.
---
# Verifying this change
- E2E tests are passing ✅
- Some new unit tests for the `PersistedRemoteFunctionValues` are added for coverage on the user contract regarding mutating state values with a mismatching typename.
- Manually running the Python greeter example should also work properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman commented on a change in pull request #195: [FLINK-21171] Wire in TypedValue throughout the runtime as state values and message payloads
Posted by GitBox <gi...@apache.org>.
igalshilman commented on a change in pull request #195:
URL: https://github.com/apache/flink-statefun/pull/195#discussion_r566851179
##########
File path: statefun-flink/statefun-flink-common/pom.xml
##########
@@ -84,10 +88,63 @@ under the License.
<build>
<plugins>
+ <!--
Review comment:
It seems like building the SDK protos is only needed for the `TypedValueUtil`. What do you think about moving it closer to the usage by duplicating it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tzulitai closed pull request #195: [FLINK-21171] Wire in TypedValue throughout the runtime as state values and message payloads
Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #195:
URL: https://github.com/apache/flink-statefun/pull/195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org