You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ranjana Rajendran (JIRA)" <ji...@apache.org> on 2014/09/28 07:19:35 UTC

[jira] [Commented] (HBASE-9741) Remove hbase.regions.slop from hbase-default.xml

    [ https://issues.apache.org/jira/browse/HBASE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150977#comment-14150977 ] 

Ranjana Rajendran commented on HBASE-9741:
------------------------------------------

The test was written for the old balancer and took the default value in defaults.xml which was 0.2f to prevent the stochastic balancer from searching for a new base. With this value of 0.2f removed from defaults.xml, was then taking the default value of 0.1f specified in the line ("float slop = (float)UTIL.getConfiguration().getFloat("hbase.regions.slop", 0.1f);") which made the test fail as this made the balancer search for a better fit which was not the intention of this test.

I would like to understand why this test is required, i.e. why is this test required to assert that regions are balanced using the function assertRegionsAreBalanced() ? If this test need to be rewritten, I would like to take up this task. Highly appreciate any input how to rewrite it different from the patch above. 

> Remove hbase.regions.slop from hbase-default.xml
> ------------------------------------------------
>
>                 Key: HBASE-9741
>                 URL: https://issues.apache.org/jira/browse/HBASE-9741
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Elliott Clark
>              Labels: beginner
>         Attachments: HBASE-9741-v0.patch, HBASE-9741-v1.patch, HBASE-9741-v3.patch, HBASE-9741-v4.patch
>
>
> Different balancers have different slop default values.  We should remove hbase.regions.slop from hbase-default.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)