You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/03/21 18:49:45 UTC
Review Request 32369: Simplify port name association.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32369/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
I realized that `StateManagerImpl` had an unnecessarily-complex function to associate assigned ports with port names, with error checking along the way. I have simplified this function and relocated it closer to where ports are assigned.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 93fc05ef8b4cad187b1d36d05d2b4bb509ed60e7
src/main/java/org/apache/aurora/scheduler/state/StateManager.java 50ff4ec915352ead8c03f494f38522bcdeca3617
src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 8721466b935da22ac9dd491b06f5e7ddc7f913e1
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c44ff339b94cac20f4fb7e69a8e403fd63c132ca
src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 17b170261b87506078d5463a5ed55fbc1cd33338
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 06a19038f99f88d28c5548055bd82b0aebb461ac
Diff: https://reviews.apache.org/r/32369/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32369: Simplify port name association.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32369/#review77417
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On March 21, 2015, 5:49 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32369/
> -----------------------------------------------------------
>
> (Updated March 21, 2015, 5:49 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I realized that `StateManagerImpl` had an unnecessarily-complex function to associate assigned ports with port names, with error checking along the way. I have simplified this function and relocated it closer to where ports are assigned.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 93fc05ef8b4cad187b1d36d05d2b4bb509ed60e7
> src/main/java/org/apache/aurora/scheduler/state/StateManager.java 50ff4ec915352ead8c03f494f38522bcdeca3617
> src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 8721466b935da22ac9dd491b06f5e7ddc7f913e1
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c44ff339b94cac20f4fb7e69a8e403fd63c132ca
> src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 17b170261b87506078d5463a5ed55fbc1cd33338
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 06a19038f99f88d28c5548055bd82b0aebb461ac
>
> Diff: https://reviews.apache.org/r/32369/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32369: Simplify port name association.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32369/#review77344
-----------------------------------------------------------
Ship it!
Master (a3a35e9) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 21, 2015, 5:49 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32369/
> -----------------------------------------------------------
>
> (Updated March 21, 2015, 5:49 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I realized that `StateManagerImpl` had an unnecessarily-complex function to associate assigned ports with port names, with error checking along the way. I have simplified this function and relocated it closer to where ports are assigned.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 93fc05ef8b4cad187b1d36d05d2b4bb509ed60e7
> src/main/java/org/apache/aurora/scheduler/state/StateManager.java 50ff4ec915352ead8c03f494f38522bcdeca3617
> src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 8721466b935da22ac9dd491b06f5e7ddc7f913e1
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c44ff339b94cac20f4fb7e69a8e403fd63c132ca
> src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 17b170261b87506078d5463a5ed55fbc1cd33338
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 06a19038f99f88d28c5548055bd82b0aebb461ac
>
> Diff: https://reviews.apache.org/r/32369/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>