[GitHub] [pulsar] 315157973 commented on a change in pull request #12015: Fix update ledger list to znode version mismatch failed, ledger not delete

[GitBox <gi...@apache.org>]

315157973 commented on a change in pull request #12015:
URL: https://github.com/apache/pulsar/pull/12015#discussion_r706857155



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -1466,6 +1452,20 @@ public void operationFailed(MetaStoreException e) {
 
                     metadataMutex.unlock();
 
+                    if (e instanceof BadVersionException) {

Review comment:
       Do we need to put this logic before releasing the lock? Now we changed the previous behavior. I'm not sure if it will cause other thread safety issues




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org