You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by deathbearbrown <gi...@git.apache.org> on 2014/02/28 15:06:45 UTC
[GitHub] couchdb pull request: 2127-config-edit-row
GitHub user deathbearbrown opened a pull request:
https://github.com/apache/couchdb/pull/160
2127-config-edit-row
Fixed the configs to be double click to edit.
Fixed the templates to not use IDs as selectors (BAD! Not blaming anyone... )
Fixed the underscore values for inputs to be HTML-escaped
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb 2127-config-edit-row
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 54312fa2ad1d31e6af603ef4a90a7560bf69bc9f
Author: suelockwood <de...@apache.org>
Date: 2014-02-27T21:52:16Z
Fixed the configs to be double click to edit.
Fixed the templates to not use IDs as selectors (BAD)
Fixed the underscore values for inputs to be HTML-escaped
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: 2127-config-edit-row
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/160#issuecomment-36357924
BTW the next UI theming update is coming very soon. We have all the comps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: 2127-config-edit-row
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/160#issuecomment-36358543
Agree. Ok, last thing then: how about centrification?
http://i.imgur.com/JTjHmJL.png
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: 2127-config-edit-row
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/160#issuecomment-36356399
Hm...why rows are so big? They creates a sense of a lot empty space and also makes page very big:
http://imgur.com/shIuEPO,JTs2q5C
On second screenshot I drop their height and as you may see there are a much more content available on the same page-size. However, I'm not sure will such height be usable on tablets - my Nexus needs for some battery change first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: 2127-config-edit-row
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/160#issuecomment-36357877
I don't want anything to jump when you click into edit the element.
We have an over all theme for input fields that I want to keep consistent. If I change it in one place it's going to start looking crappy and I don't want to go down that road.
On the next UI update for theming we can address the padding on those.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: 2127-config-edit-row
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown closed the pull request at:
https://github.com/apache/couchdb/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: 2127-config-edit-row
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb/pull/160#issuecomment-37209252
I centered it. I'm pushing it to master because I need it for other edits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: 2127-config-edit-row
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/160#issuecomment-37209668
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---