You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Erik Hatcher <er...@ehatchersolutions.com> on 2003/09/18 20:36:06 UTC
cleanup questions
In my efforts to create a clean demo application I'm doing a thorough
review of the codebase and directory structure. I'll likely have more
questions over time, but here are some to get the ball rolling....
- src/test/org/apache/lucene/IndexTest.java - this is not even a JUnit
test case. Does anyone run it? It has a hardcoded path ("F:\test")
and some FIXME comments. The code is totally useless except to someone
with F:\test and F:\recipes. Any objections to just removing this file?
- src/test/org/apache/lucene/index/DocTest.java - this one may actually
be slightly useful, but its not a JUnit test case. Could someone
convert this to a test case? Or should it be removed also?
- there are some other classes in src/test that are simply main()
routines and not JUnit tests: AnalysisTest, SearchTest,
SearchTestForDuplicates, StoreTest, ThreadSafetyTest, ant
TermInfosTest. All of these look like reasonable candidates for
conversion to true JUnit tests. Any volunteers? :) I'll likely give
it a go one of these days. The sad thing is that these probably have
some reasonable tests in them that aren't ever going to get run except
manually.
Some of these might actually make sense in the context of JUnitPerf
type tests to get some baseline timing tests and ensure that any future
changes to the core don't push index or search times out of expected
ranges.
- Finally, is src/demo/Search.html or Search.jthml still in use? Heck,
I don't even know what jhtml is other than some type of servlet-like
thing, so I doubt its being used.
Thanks,
Erik
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: cleanup questions
Posted by Doug Cutting <cu...@lucene.com>.
Erik Hatcher wrote:
> - src/test/org/apache/lucene/IndexTest.java - this is not even a JUnit
> test case. Does anyone run it? It has a hardcoded path ("F:\test") and
> some FIXME comments. The code is totally useless except to someone with
> F:\test and F:\recipes. Any objections to just removing this file?
>
> - src/test/org/apache/lucene/index/DocTest.java - this one may actually
> be slightly useful, but its not a JUnit test case. Could someone
> convert this to a test case? Or should it be removed also?
>
> - there are some other classes in src/test that are simply main()
> routines and not JUnit tests: AnalysisTest, SearchTest,
> SearchTestForDuplicates, StoreTest, ThreadSafetyTest, ant
> TermInfosTest.
I think these are mostly things from back when I first wrote Lucene,
before there was a JUnit.
> Some of these might actually make sense in the context of JUnitPerf type
> tests to get some baseline timing tests and ensure that any future
> changes to the core don't push index or search times out of expected
> ranges.
That'd be great!
> - Finally, is src/demo/Search.html or Search.jthml still in use? Heck,
> I don't even know what jhtml is other than some type of servlet-like
> thing, so I doubt its being used.
Jhtml was the precursor to jsp, in the original JWS, before Tomcat. It
is indeed archaic.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: cleanup questions
Posted by Doug Cutting <cu...@lucene.com>.
Erik Hatcher wrote:
> - src/test/org/apache/lucene/IndexTest.java - this is not even a JUnit
> test case. Does anyone run it? It has a hardcoded path ("F:\test") and
> some FIXME comments. The code is totally useless except to someone with
> F:\test and F:\recipes. Any objections to just removing this file?
>
> - src/test/org/apache/lucene/index/DocTest.java - this one may actually
> be slightly useful, but its not a JUnit test case. Could someone
> convert this to a test case? Or should it be removed also?
>
> - there are some other classes in src/test that are simply main()
> routines and not JUnit tests: AnalysisTest, SearchTest,
> SearchTestForDuplicates, StoreTest, ThreadSafetyTest, ant
> TermInfosTest.
I think these are mostly things from back when I first wrote Lucene,
before there was a JUnit.
> Some of these might actually make sense in the context of JUnitPerf type
> tests to get some baseline timing tests and ensure that any future
> changes to the core don't push index or search times out of expected
> ranges.
That'd be great!
> - Finally, is src/demo/Search.html or Search.jthml still in use? Heck,
> I don't even know what jhtml is other than some type of servlet-like
> thing, so I doubt its being used.
Jhtml was the precursor to jsp, in the original JWS, before Tomcat. It
is indeed archaic.
Doug
Re: cleanup questions
Posted by Otis Gospodnetic <ot...@yahoo.com>.
--- Erik Hatcher <er...@ehatchersolutions.com> wrote:
> In my efforts to create a clean demo application I'm doing a thorough
>
> review of the codebase and directory structure. I'll likely have
> more
> questions over time, but here are some to get the ball rolling....
>
> - src/test/org/apache/lucene/IndexTest.java - this is not even a
> JUnit
> test case. Does anyone run it? It has a hardcoded path ("F:\test")
> and some FIXME comments. The code is totally useless except to
> someone
> with F:\test and F:\recipes. Any objections to just removing this
> file?
I don't have the sources handy, so I can't check, but if there is
anything in there that is useful, even if it's not in JUnit format, I
wouldn't remove it from CVS.
> - src/test/org/apache/lucene/index/DocTest.java - this one may
> actually
> be slightly useful, but its not a JUnit test case. Could someone
> convert this to a test case? Or should it be removed also?
Don't remove it yet, please. Give me a few days to take a look at it.
Otis
__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org
Re: cleanup questions
Posted by Otis Gospodnetic <ot...@yahoo.com>.
--- Erik Hatcher <er...@ehatchersolutions.com> wrote:
> In my efforts to create a clean demo application I'm doing a thorough
>
> review of the codebase and directory structure. I'll likely have
> more
> questions over time, but here are some to get the ball rolling....
>
> - src/test/org/apache/lucene/IndexTest.java - this is not even a
> JUnit
> test case. Does anyone run it? It has a hardcoded path ("F:\test")
> and some FIXME comments. The code is totally useless except to
> someone
> with F:\test and F:\recipes. Any objections to just removing this
> file?
I don't have the sources handy, so I can't check, but if there is
anything in there that is useful, even if it's not in JUnit format, I
wouldn't remove it from CVS.
> - src/test/org/apache/lucene/index/DocTest.java - this one may
> actually
> be slightly useful, but its not a JUnit test case. Could someone
> convert this to a test case? Or should it be removed also?
Don't remove it yet, please. Give me a few days to take a look at it.
Otis
__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com