You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/26 08:10:57 UTC

[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #19563: Optimizing worker-id generation by in-memory computing in cluster mode

TeslaCN commented on code in PR #19563:
URL: https://github.com/apache/shardingsphere/pull/19563#discussion_r929657986


##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/instance/ComputeNodeInstance.java:
##########
@@ -41,6 +41,8 @@ public final class ComputeNodeInstance {
     
     private Collection<String> labels = new ArrayList<>();
     
+    private volatile Long workerId;

Review Comment:
   Could we change this to primitive type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org