[GitHub] jon-wei commented on a change in pull request #6380: fix issue with parsing 'date' columns with druid-orc-extensions

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #6380: fix issue with parsing 'date' columns with druid-orc-extensions
URL: https://github.com/apache/incubator-druid/pull/6380#discussion_r220392444
 
 

 ##########
 File path: extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java
 ##########
 @@ -228,7 +229,13 @@ static String typeStringFromParseSpec(ParseSpec parseSpec)
     builder.append(parseSpec.getTimestampSpec().getTimestampColumn()).append(":string");
     if (parseSpec.getDimensionsSpec().getDimensionNames().size() > 0) {
       builder.append(",");
-      builder.append(String.join(":string,", parseSpec.getDimensionsSpec().getDimensionNames()));
+      builder.append(String.join(
 
 Review comment:
   can you add a comment on why filtering out the timestamp here is necessary

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org