You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2015/12/03 15:01:11 UTC
[jira] [Commented] (SPARK-5312) Use sbt to detect new or changed
public classes in PRs
[ https://issues.apache.org/jira/browse/SPARK-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037808#comment-15037808 ]
Sean Owen commented on SPARK-5312:
----------------------------------
[~boyork] are you going to do more with this?
> Use sbt to detect new or changed public classes in PRs
> ------------------------------------------------------
>
> Key: SPARK-5312
> URL: https://issues.apache.org/jira/browse/SPARK-5312
> Project: Spark
> Issue Type: Improvement
> Components: Project Infra
> Reporter: Nicholas Chammas
> Priority: Minor
>
> We currently use an [unwieldy grep/sed contraption|https://github.com/apache/spark/blob/19556454881e05a6c2470d406d50f004b88088a2/dev/run-tests-jenkins#L152-L174] to detect new public classes in PRs.
> -Apparently, sbt lets you get a list of public classes [much more directly|http://www.scala-sbt.org/0.13/docs/Howto-Inspect-the-Build.html] via {{show compile:discoveredMainClasses}}. We should use that instead.-
> There is a tool called [ClassUtil|http://software.clapper.org/classutil/] that seems to help give this kind of information much more directly. We should look into using that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org