回复： Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2

[bismy <bi...@qq.com>]

I agree to support Spring Boot 2. The only thing is that we need first work on it and find any potential problem need to be addressed. Anyone want have a try?




------------------ 原始邮件 ------------------
发件人: "willem.jiang"<wi...@gmail.com>;
发送时间: 2018年7月20日(星期五) 上午10:50
收件人: "dev"<de...@servicecomb.apache.org>;

主题: Re: Re: [DISCUSS]Shall we upgrade Java-chassis to support Spring Boot2



It think we can update our bean.xml file for 4.0.xsd.
If I remember right the spring namespace handler can take care of mapping
http url to classpath.


Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Fri, Jul 20, 2018 at 10:36 AM, wjm wjm <zz...@gmail.com> wrote:

> about " classpath:org/springframework/beans/factory/xml/spring-
> beans-3.0.xsd"
>
> if changed to http://....., and if net disconnected, then process will
> blocked when booting
> this already happened many times in our environment and
> customer's environment
>
> we need to make a decision of this.
>
> 2018-07-20 10:29 GMT+08:00 yhs0092 <yh...@163.com>:
>
> > I tried to upgrade Java-Chassis to support SpringBoot2 before, but
> failed.
> >
> >
> > There are two problems. The first one is in our bean.xml file， the xsd
> > file is imported like below:
> > ```
> > classpath:org/springframework/beans/factory/xml/spring-beans-3.0.xsd
> > ```
> > but 3.0 version xsd file does not exist anymore.
> >
> > This is still resolvable, but for the second problem, I still haven't
> > found a way to resolve it.
> >
> >
> > When my service demo is started, an error occurs:
> > ```
> > 2018-03-13 22:57:18.396  WARN 11116 --- [           main]
> > ConfigServletWebServerApplicationContext : Exception encountered during
> > context initialization - cancelling refresh attempt:
> > org.springframework.beans.factory.BeanDefinitionStoreException: Failed
> to
> > parse configuration class [org.apache.servicecomb.
> > springboot.starter.transport.RestServletInitializer]; nested exception
> is
> > java.io.FileNotFoundException: class path resource
> > [org/springframework/boot/context/embedded/
> AbstractConfigurableEmbeddedServletContainer.class]
> > cannot be opened because it does not exist
> > ```
> > Because AbstractConfigurableEmbeddedServletContainer is removed in
> > SpringBoot2, and our RestServletInitializer is extended from this class,
> > maybe we cannot upgrade to SpringBoot2 by simply change the maven
> > dependency.
> > And once we refactor our RestServletInitializer, the java-chassis may not
> > be compatible with SpringBoot1.
> >
> >
> >
> > 在 2018-07-20 08:57:05，"wjm wjm" <zz...@gmail.com> 写道：
> > >not enough, must exclude old spring also
> > >
> > >2018-07-20 6:44 GMT+08:00 Willem Jiang <wi...@gmail.com>:
> > >
> > >> How about let user override the version of Spring Boot in their
> > application
> > >> and give it a try.
> > >> Just like what we do with JDK9 here[1]
> > >> If there is any issue comes out, we can keep digging it.
> > >>
> > >> [1]https://github.com/apache/incubator-servicecomb-saga/issues/76
> > >>
> > >>
> > >> Willem Jiang
> > >>
> > >> Twitter: willemjiang
> > >> Weibo: 姜宁willem
> > >>
> > >> On Thu, Jul 19, 2018 at 8:26 PM, Bin Ma <ma...@gmail.com> wrote:
> > >>
> > >> > Hi,
> > >> >   Java-chassis currently supports Spirng Boot 1.5.12 version.
> > >> >
> > >> >   In fact, some enterprise users develop their coursewares based on
> > >> Spring
> > >> > Boot2, so hopefully Java-chassis can support Spring Boot2, such as
> > >> Chuanzhi
> > >> > Boke.
> > >> >
> > >> >   I think it's neccessary to discuss the plan about  upgrading
> > >> > Java-Chasssis to support  Spring Boot2 to satisfy users' scenario.
> > >> >
> > >> >   Any thoughts and any troubles to upgrading, please feel free to
> > discuss
> > >> > here.
> > >> >
> > >>
> >
>