You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2017/03/24 20:19:42 UTC

svn commit: r1788537 - /commons/proper/net/trunk/src/main/java/examples/ftp/TFTPExample.java

Author: sebb
Date: Fri Mar 24 20:19:42 2017
New Revision: 1788537

URL: http://svn.apache.org/viewvc?rev=1788537&view=rev
Log:
Avoid System.exit

Modified:
    commons/proper/net/trunk/src/main/java/examples/ftp/TFTPExample.java

Modified: commons/proper/net/trunk/src/main/java/examples/ftp/TFTPExample.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/examples/ftp/TFTPExample.java?rev=1788537&r1=1788536&r2=1788537&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/examples/ftp/TFTPExample.java (original)
+++ commons/proper/net/trunk/src/main/java/examples/ftp/TFTPExample.java Fri Mar 24 20:19:42 2017
@@ -163,9 +163,7 @@ public final class TFTPExample
         catch (IOException e)
         {
             tftp.close();
-            System.err.println("Error: could not open local file for reading.");
-            System.err.println(e.getMessage());
-            System.exit(1);
+            throw new RuntimeException("Error: could not open local file for reading.", e);
         }
 
         open(tftp);
@@ -213,7 +211,7 @@ public final class TFTPExample
         if (file.exists())
         {
             System.err.println("Error: " + localFilename + " already exists.");
-            System.exit(1);
+            return false;
         }
 
         // Try to open local file for writing
@@ -224,9 +222,7 @@ public final class TFTPExample
         catch (IOException e)
         {
             tftp.close();
-            System.err.println("Error: could not open local file for writing.");
-            System.err.println(e.getMessage());
-            System.exit(1);
+            throw new RuntimeException("Error: could not open local file for writing.", e);
         }
 
         open(tftp);
@@ -289,9 +285,7 @@ public final class TFTPExample
         }
         catch (SocketException e)
         {
-            System.err.println("Error: could not open local UDP socket.");
-            System.err.println(e.getMessage());
-            System.exit(1);
+            throw new RuntimeException("Error: could not open local UDP socket.", e);
         }
     }