You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/16 09:47:31 UTC
[GitHub] [cloudstack] ravening opened a new pull request #5114: Display all volumes to root admin
ravening opened a new pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114
### Description
Currently only volume of User vm's are displayed in api.
Display all volumes to root admins so that its easy to see
rather than doing some sql queries
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1038490982
<b>Trillian test result (tid-3318)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35291 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5114-t3318-kvm-centos7.zip
Smoke tests completed. 80 look OK, 12 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestTemplates>:setup | `Error` | 246.41 | test_templates.py
test_07_project_resources_account_delete | `Error` | 5.45 | test_projects.py
test_08_cleanup_after_project_delete | `Error` | 5.81 | test_projects.py
test_01_deploy_vms_storage_tags | `Error` | 5.47 | test_primary_storage.py
test_03_migration_options_storage_tags | `Error` | 31.69 | test_primary_storage.py
test_01_create_volume | `Error` | 3.28 | test_volumes.py
test_02_attach_volume | `Error` | 206.12 | test_volumes.py
test_05_detach_volume | `Error` | 208.49 | test_volumes.py
test_07_resize_fail | `Error` | 114.29 | test_volumes.py
test_08_resize_volume | `Error` | 119.62 | test_volumes.py
test_09_delete_detached_volume | `Error` | 118.66 | test_volumes.py
test_10_list_volumes | `Error` | 113.25 | test_volumes.py
test_11_attach_volume_with_unstarted_vm | `Error` | 129.78 | test_volumes.py
test_11_migrate_volume_and_change_offering | `Error` | 246.31 | test_volumes.py
test_12_resize_volume_with_only_size_parameter | `Error` | 120.64 | test_volumes.py
test_01_snapshot_usage | `Error` | 0.02 | test_usage.py
test_01_volume_usage | `Error` | 124.42 | test_usage.py
test_list_volumes_metrics | `Error` | 1.30 | test_metrics_api.py
test_00_deploy_vm_root_resize | `Error` | 66.00 | test_deploy_vm_root_resize.py
test_01_reset_vm_on_reboot | `Error` | 0.02 | test_reset_vm_on_reboot.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_11_destroy_vm_and_volumes | `Error` | 46.65 | test_vm_life_cycle.py
test_01_snapshot_root_disk | `Error` | 0.02 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 1.14 | test_snapshots.py
test_hostha_enable_ha_when_host_disabled | `Error` | 3.61 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.84 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-992720528
<b>Trillian test result (tid-2647)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31073 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5114-t2647-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti closed pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-895334459
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-863661440
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1034067754
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1044290691
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-988653482
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-900893108
@nvazquez addressed your comments. please review it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1043838318
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1038141248
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1037243085
<b>Trillian test result (tid-3310)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42331 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5114-t3310-kvm-centos7.zip
Smoke tests completed. 81 look OK, 11 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestTemplates>:setup | `Error` | 273.98 | test_templates.py
test_07_project_resources_account_delete | `Error` | 5.43 | test_projects.py
test_08_cleanup_after_project_delete | `Error` | 5.89 | test_projects.py
test_01_deploy_vms_storage_tags | `Error` | 4.50 | test_primary_storage.py
test_03_migration_options_storage_tags | `Error` | 31.66 | test_primary_storage.py
test_01_create_volume | `Error` | 3.29 | test_volumes.py
test_02_attach_volume | `Error` | 205.35 | test_volumes.py
test_05_detach_volume | `Error` | 208.46 | test_volumes.py
test_07_resize_fail | `Error` | 114.27 | test_volumes.py
test_08_resize_volume | `Error` | 121.58 | test_volumes.py
test_09_delete_detached_volume | `Error` | 117.60 | test_volumes.py
test_10_list_volumes | `Error` | 114.34 | test_volumes.py
test_11_attach_volume_with_unstarted_vm | `Error` | 128.80 | test_volumes.py
test_11_migrate_volume_and_change_offering | `Error` | 247.16 | test_volumes.py
test_12_resize_volume_with_only_size_parameter | `Error` | 120.53 | test_volumes.py
test_01_snapshot_usage | `Error` | 0.02 | test_usage.py
test_01_volume_usage | `Error` | 123.50 | test_usage.py
test_list_volumes_metrics | `Error` | 1.30 | test_metrics_api.py
test_00_deploy_vm_root_resize | `Error` | 67.09 | test_deploy_vm_root_resize.py
test_01_reset_vm_on_reboot | `Error` | 0.02 | test_reset_vm_on_reboot.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_11_destroy_vm_and_volumes | `Error` | 46.72 | test_vm_life_cycle.py
test_01_snapshot_root_disk | `Error` | 0.02 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 1.14 | test_snapshots.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1036952097
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#discussion_r770336192
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2083,8 +2084,15 @@
if (clusterId != null) {
sc.setParameters("clusterId", clusterId);
}
- // Don't return DomR and ConsoleProxy volumes
- sc.setParameters("type", VirtualMachine.Type.ConsoleProxy, VirtualMachine.Type.SecondaryStorageVm, VirtualMachine.Type.DomainRouter);
+
+ sc.setParameters("type", VirtualMachine.Type.User);
+
+ // Display all volumes for ROOT admin
+ if (forSystemVms != null && forSystemVms && caller.getType() == Account.ACCOUNT_TYPE_ADMIN) {
Review comment:
+1 on @nvazquez suggestions, it looks like a simple way of improving the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-921235658
ping @ravening, can you address the outstanding review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-988504749
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-988504550
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-988588088
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-925601843
Hi @ravening, can you resolve the outstanding comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1043777315
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1044290011
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-900893108
@nvazquez addressed your comments. please review it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#discussion_r710890600
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2083,8 +2084,15 @@
if (clusterId != null) {
sc.setParameters("clusterId", clusterId);
}
- // Don't return DomR and ConsoleProxy volumes
- sc.setParameters("type", VirtualMachine.Type.ConsoleProxy, VirtualMachine.Type.SecondaryStorageVm, VirtualMachine.Type.DomainRouter);
+
+ sc.setParameters("type", VirtualMachine.Type.User);
+
+ // Display all volumes for ROOT admin
+ if (forSystemVms != null && forSystemVms && caller.getType() == Account.ACCOUNT_TYPE_ADMIN) {
Review comment:
I still need `sc.setParameters("systemUse", 0, 1);` and others can be avoided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-895232655
> @ravening what do you think adding a new parameter (for example systemuse) to ListVolumes api ?
@weizhouapache added a new parameter for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1033781171
> Hi @ravening can you please fix the conflicts?
@nvazquez done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1034475736
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1038141658
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#discussion_r691751398
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2083,8 +2084,15 @@
if (clusterId != null) {
sc.setParameters("clusterId", clusterId);
}
- // Don't return DomR and ConsoleProxy volumes
- sc.setParameters("type", VirtualMachine.Type.ConsoleProxy, VirtualMachine.Type.SecondaryStorageVm, VirtualMachine.Type.DomainRouter);
+
+ sc.setParameters("type", VirtualMachine.Type.User);
+
+ // Display all volumes for ROOT admin
+ if (forSystemVms != null && forSystemVms && caller.getType() == Account.ACCOUNT_TYPE_ADMIN) {
Review comment:
What about extracting this condition into a new method, such as:
````
boolean isAdminRequestingAllVolumes(Boolean forSystemVms, Account caller) {
return forSystemVms != null && forSystemVms && caller.getType() == Account.ACCOUNT_TYPE_ADMIN;
}
````
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2006,9 +2007,9 @@
sb.and("display", sb.entity().isDisplayVolume(), SearchCriteria.Op.EQ);
sb.and("state", sb.entity().getState(), SearchCriteria.Op.EQ);
sb.and("stateNEQ", sb.entity().getState(), SearchCriteria.Op.NEQ);
- sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.NEQ);
+ sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.IN);
Review comment:
Then we won't need this change
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2083,8 +2084,15 @@
if (clusterId != null) {
sc.setParameters("clusterId", clusterId);
}
- // Don't return DomR and ConsoleProxy volumes
- sc.setParameters("type", VirtualMachine.Type.ConsoleProxy, VirtualMachine.Type.SecondaryStorageVm, VirtualMachine.Type.DomainRouter);
Review comment:
Same here:
````
if (!isAdminRequestingAllVolumes(forSystemVms, caller) {
// Don't return DomR and ConsoleProxy volumes
sc.setParameters("type", VirtualMachine.Type.ConsoleProxy, VirtualMachine.Type.SecondaryStorageVm, VirtualMachine.Type.DomainRouter);
}
````
And we won't need all the lines added below
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2006,9 +2007,9 @@
sb.and("display", sb.entity().isDisplayVolume(), SearchCriteria.Op.EQ);
sb.and("state", sb.entity().getState(), SearchCriteria.Op.EQ);
sb.and("stateNEQ", sb.entity().getState(), SearchCriteria.Op.NEQ);
- sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.NEQ);
+ sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.IN);
// display UserVM volumes only
- sb.and().op("type", sb.entity().getVmType(), SearchCriteria.Op.NIN);
+ sb.and().op("type", sb.entity().getVmType(), SearchCriteria.Op.IN);
Review comment:
Or this
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2035,7 +2036,7 @@
setIdsListToSearchCriteria(sc, ids);
- sc.setParameters("systemUse", 1);
+ sc.setParameters("systemUse", 0);
Review comment:
This could be reverted as well, to:
````
if (!isAdminRequestingAllVolumes(forSystemVms, caller) {
sc.setParameters("systemUse", 1);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-883816058
Hi @ravening, I agree with @weizhouapache's comment, would you consider including that parameter on the listVolumes API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1034068030
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1046581951
the same set of failures is pretty consistent @ravening. I think you'll need to look at the results and code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1044368500
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1044524493
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1043779009
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-895357239
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#discussion_r710890046
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2006,9 +2007,9 @@
sb.and("display", sb.entity().isDisplayVolume(), SearchCriteria.Op.EQ);
sb.and("state", sb.entity().getState(), SearchCriteria.Op.EQ);
sb.and("stateNEQ", sb.entity().getState(), SearchCriteria.Op.NEQ);
- sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.NEQ);
+ sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.IN);
Review comment:
@nvazquez I still need this change since I need to assign both 0 and 1 for root admin
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2006,9 +2007,9 @@
sb.and("display", sb.entity().isDisplayVolume(), SearchCriteria.Op.EQ);
sb.and("state", sb.entity().getState(), SearchCriteria.Op.EQ);
sb.and("stateNEQ", sb.entity().getState(), SearchCriteria.Op.NEQ);
- sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.NEQ);
+ sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.IN);
// display UserVM volumes only
- sb.and().op("type", sb.entity().getVmType(), SearchCriteria.Op.NIN);
+ sb.and().op("type", sb.entity().getVmType(), SearchCriteria.Op.IN);
Review comment:
this can be avoided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1034476027
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1036952241
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-992236364
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#discussion_r686466300
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2083,8 +2084,15 @@
if (clusterId != null) {
sc.setParameters("clusterId", clusterId);
}
- // Don't return DomR and ConsoleProxy volumes
- sc.setParameters("type", VirtualMachine.Type.ConsoleProxy, VirtualMachine.Type.SecondaryStorageVm, VirtualMachine.Type.DomainRouter);
+
+ sc.setParameters("type", VirtualMachine.Type.User);
+
+ // Display all volumes for ROOT admin
+ if (forSystemVms && caller.getType() == Account.ACCOUNT_TYPE_ADMIN) {
Review comment:
At this point `forSystemVms` may produce a `NullPointerException`
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
##########
@@ -136,6 +140,10 @@ public String getStorageId() {
return storageId;
}
+ public Boolean getForsystemvm() {
+ return forsystemvm;
Review comment:
To prevent the NPE I would propose to change this for: `BooleanUtils.isTrue(forsystemvm)`
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java
##########
@@ -92,6 +92,10 @@
@Parameter(name = ApiConstants.STATE, type = CommandType.STRING, description = "state of the volume. Possible values are: Ready, Allocated, Destroy, Expunging, Expunged.")
private String state;
+ @Parameter(name = ApiConstants.FOR_SYSTEM_VMS, type = CommandType.BOOLEAN, description = "list volumes of systemvms and routervm", since = "4.16", authorized = {
+ RoleType.Admin})
+ private Boolean forsystemvm;
Review comment:
Minor: can you rename this field and its getter to camelcase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-895334123
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-895356942
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-988543274
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-992234059
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-987766108
> @ravening travis really goes beserk on this one, can you check it, please?
@DaanHoogland can you retrigger this? my change is just to list the volumes and Im not sure how is that affecting all these tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-988588321
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1031032747
Hi @ravening can you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1034091593
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 2547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1034504638
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1045509568
<b>Trillian test result (tid-3389)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42176 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5114-t3389-kvm-centos7.zip
Smoke tests completed. 81 look OK, 11 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestTemplates>:setup | `Error` | 250.64 | test_templates.py
test_07_project_resources_account_delete | `Error` | 5.40 | test_projects.py
test_08_cleanup_after_project_delete | `Error` | 7.03 | test_projects.py
test_01_deploy_vms_storage_tags | `Error` | 5.44 | test_primary_storage.py
test_03_migration_options_storage_tags | `Error` | 31.75 | test_primary_storage.py
test_01_create_volume | `Error` | 3.35 | test_volumes.py
test_02_attach_volume | `Error` | 205.12 | test_volumes.py
test_05_detach_volume | `Error` | 208.84 | test_volumes.py
test_07_resize_fail | `Error` | 114.39 | test_volumes.py
test_08_resize_volume | `Error` | 118.68 | test_volumes.py
test_09_delete_detached_volume | `Error` | 127.64 | test_volumes.py
test_10_list_volumes | `Error` | 114.42 | test_volumes.py
test_11_attach_volume_with_unstarted_vm | `Error` | 170.84 | test_volumes.py
test_11_migrate_volume_and_change_offering | `Error` | 254.28 | test_volumes.py
test_12_resize_volume_with_only_size_parameter | `Error` | 123.55 | test_volumes.py
test_01_snapshot_usage | `Error` | 0.02 | test_usage.py
test_01_volume_usage | `Error` | 123.43 | test_usage.py
test_list_volumes_metrics | `Error` | 1.28 | test_metrics_api.py
test_00_deploy_vm_root_resize | `Error` | 66.00 | test_deploy_vm_root_resize.py
test_01_reset_vm_on_reboot | `Error` | 0.02 | test_reset_vm_on_reboot.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_11_destroy_vm_and_volumes | `Error` | 46.69 | test_vm_life_cycle.py
test_01_snapshot_root_disk | `Error` | 0.03 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 1.13 | test_snapshots.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1044523923
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1037243085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-863661789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-895355597
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-896331665
<b>Trillian test result (tid-1559)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 103201 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5114-t1559-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 62 look OK, 27 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 510.65 | test_internal_lb.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.40 | test_iso.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.40 | test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative | `Error` | 66.43 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.41 | test_iso.py
test_03_1_create_iso_with_checksum_md5_negative | `Error` | 66.39 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.40 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.40 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.40 | test_iso.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
test_list_clusters_metrics | `Error` | 1511.65 | test_metrics_api.py
test_list_vms_metrics | `Error` | 0.15 | test_metrics_api.py
test_list_volumes_metrics | `Error` | 1.27 | test_metrics_api.py
test_00_deploy_vm_root_resize | `Error` | 75.30 | test_deploy_vm_root_resize.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1515.12 | test_domain_service_offerings.py
ContextSuite context=TestKubernetesCluster>:setup | `Error` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 1801.73 | test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_nic_secondaryip_add_remove | `Error` | 1511.73 | test_multipleips_per_nic.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
test_01_deploy_vms_storage_tags | `Error` | 7.76 | test_primary_storage.py
test_03_migration_options_storage_tags | `Error` | 31.95 | test_primary_storage.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
test_07_project_resources_account_delete | `Error` | 5.42 | test_projects.py
test_08_cleanup_after_project_delete | `Error` | 6.04 | test_projects.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1518.82 | test_projects.py
test_01_reset_vm_on_reboot | `Error` | 0.01 | test_reset_vm_on_reboot.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 342.13 | test_routers_network_ops.py
test_01_snapshot_root_disk | `Error` | 0.02 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 1.19 | test_snapshots.py
ContextSuite context=TestTemplates>:setup | `Error` | 264.38 | test_templates.py
test_01_snapshot_usage | `Error` | 0.02 | test_usage.py
test_01_volume_usage | `Error` | 124.59 | test_usage.py
test_11_destroy_vm_and_volumes | `Error` | 47.75 | test_vm_life_cycle.py
test_01_create_volume | `Error` | 3.28 | test_volumes.py
test_02_attach_volume | `Error` | 207.74 | test_volumes.py
test_05_detach_volume | `Error` | 255.08 | test_volumes.py
test_07_resize_fail | `Error` | 119.94 | test_volumes.py
test_08_resize_volume | `Error` | 121.52 | test_volumes.py
test_09_delete_detached_volume | `Error` | 119.67 | test_volumes.py
test_10_list_volumes | `Error` | 149.89 | test_volumes.py
test_11_attach_volume_with_unstarted_vm | `Error` | 139.89 | test_volumes.py
test_11_migrate_volume_and_change_offering | `Error` | 252.34 | test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 518.04 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 471.73 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 470.99 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 471.00 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-987765327
> Hi @ravening, can you resolve the outstanding comments.
@sureshanaparti sorry, I missed your comment, I have updated the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-896121661
@ravening travis really goes beserk on this one, can you check it, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5114: Display all volumes to root admin
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#issuecomment-1038141248
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org