You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/04/06 08:29:20 UTC

[GitHub] [submarine] lleohao opened a new pull request #256: SUBMARINE-307. Add notebook module

lleohao opened a new pull request #256: SUBMARINE-307. Add notebook module
URL: https://github.com/apache/submarine/pull/256
 
 
   ### What is this PR for?
   Add notebook page
   
   1. Add online editor
   2. Add result preview feature
       1. table
       2. line chart (will add more chart)
   
   ### What type of PR is it?
   [Feature]
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-307#
   
   ### How should this be tested?
   No test
   
   ### Screenshots (if appropriate)
   ![Xnip2020-04-06_16-20-29](https://user-images.githubusercontent.com/12764126/78538488-a8d5e500-7823-11ea-8dee-fd108299de3c.png)
   ![Xnip2020-04-06_16-20-34](https://user-images.githubusercontent.com/12764126/78538492-aa9fa880-7823-11ea-886c-61e9ffbfb4a6.png)
   
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] liuxunorg commented on issue #256: SUBMARINE-307. Add notebook module

Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #256: SUBMARINE-307. Add notebook module
URL: https://github.com/apache/submarine/pull/256#issuecomment-609680471
 
 
   @lleohao Thank you for contribtion this important feature.
   
   I see 3 errors in travis, it seems that they are all caused by ng compilation failure. Please fix this problem, thanks!
   https://api.travis-ci.org/v3/job/671524346/log.txt
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [submarine] yuanzac commented on issue #256: SUBMARINE-307. Add notebook module

Posted by GitBox <gi...@apache.org>.
yuanzac commented on issue #256: SUBMARINE-307. Add notebook module
URL: https://github.com/apache/submarine/pull/256#issuecomment-615839798
 
 
   @lleohao, thanks for the contribution. There is a code conflict. Can you help to take a look?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services