[GitHub] [superset] kgabryje commented on a change in pull request #12257: perf: Optimize performance of Results and Samples tables on Explore

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #12257:
URL: https://github.com/apache/superset/pull/12257#discussion_r553440052



##########
File path: superset-frontend/spec/javascripts/explore/utils_spec.jsx
##########
@@ -202,20 +201,6 @@ describe('exploreUtils', () => {
     });
   });
 
-  describe('getDataTablePageSize', () => {
-    it('divides samples data into pages dynamically', () => {
-      let pageSize;
-      pageSize = getDataTablePageSize(500);
-      expect(pageSize).toEqual(20);
-      pageSize = getDataTablePageSize(0);
-      expect(pageSize).toEqual(50);

Review comment:
       Do we actually need this test? We use a fixed number of items per page now and pagination itself is tested in `TableView_spec.tsx`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org