You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by 望哥 <ge...@gmail.com> on 2020/03/06 08:04:37 UTC
[VOTE] Release Apache dubbo-go-hessian2 v1.4.0 RC1
Hello Dubbo/Dubbogo Community,
This is a call for vote to release Apache dubbo-go-hessian2 version v1.4.0
RC1.
The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.4.0-rc1/
Git tag for the release:
https://github.com/apache/dubbo-go-hessian2/tree/1.4
Hash for the release tag: 4c31e88c35afe84c0321d9f12f036e6d3c8962d0
Release Notes:
https://github.com/apache/dubbo-go-hessian2/blob/1.4/CHANGE.md
The artifacts have been signed with Key :7DB68550D366E4C0, which can be
found in the keys file:
https://dist.apache.org/repos/dist/dev/dubbo/KEYS
The vote will be open for at least 72 hours or until necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Dubbo-go Team
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.4.0 RC1
Posted by stocks alex <al...@apache.org>.
+1 approve
I have checked:
+ signatures and hashes;
+ all sources have apache license v2 header;
+ NOTICE;
+ all unit tests runs;
Some problems need to be fixed:
1 the import block of java_exception_test.go should be splitted;
2 pls add remark for Response and EnsureResponse in response.go;
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.4.0 RC1
Posted by wongoo <wo...@apache.org>.
Hello Dubbo/Dubbogo Community,
The release dubbo-go-hessian2 v1.4.0 RC1 vote finished, We’ve received 3 +1
(binding) votes.
+1 binding, Stocks Alex
+1 binding, Ian Luo
+1 binding, Jun Liu
The vote and result thread:
https://lists.apache.org/thread.html/r8070f3b00984888069dd4ddad1bbc424cde51ea68b6ff0520e609e18%40%3Cdev.dubbo.apache.org%3E
The vote passed. Thanks all.
I will proceed with the formal release later.
Best regards,
The Apache Dubbogo Team
On Tue, Mar 10, 2020 at 10:33 AM Jun Liu <ke...@gmail.com> wrote:
> +1 binding
>
> I checked:
>
> * Signatures and hash are good
> * NOTICE and LICENSE exists;
> * Tests passed on my osx;
>
> On Mon, Mar 9, 2020 at 11:19 AM Ian Luo <ia...@gmail.com> wrote:
>
> > I checked the following items. I vote +1 (binding) to this release.
> >
> > [v] Are release files in correct location?
> > [v] Are the digital signature and hashes correct?
> > [v] Do LICENSE and NOTICE files exists?
> > [v] Is the LICENSE and NOTICE text correct?
> > [v] Is the NOTICE year correct?
> > [x] Un-included software dependencies are not mentioned in LICENSE or
> > NOTICE?
> > [x] License information is not mentioned in NOTICE?
> > [x] Is there any 3rd party code contained inside the release? If so:
> > [ ] Does the software have a compatible license?
> > [ ] Are all software licenses mentioned in LICENSE?
> > [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
> > Is any of this code Apache licensed? Do they have NOTICE files? If so:
> > [ ] Have relevant parts of those NOTICE files been added to this
> NOTICE
> > file?
> > [ ] Do all source files have ASF headers?
> > [v] Do the contents of the release match with what's tagged in version
> > control?
> > [x] Are there any unexpected binary files in the release?
> > [v] Can you compile from source? Are the instruction clear?
> >
> > I vote with:
> > [v] +1 release the software
> > [ ] +0 not sure if it should be released
> > [ ] -1 don’t release the software because..
> >
> > Regards,
> > -Ian.
> >
> > On Fri, Mar 6, 2020 at 4:04 PM 望哥 <ge...@gmail.com> wrote:
> >
> > > Hello Dubbo/Dubbogo Community,
> > >
> > > This is a call for vote to release Apache dubbo-go-hessian2 version
> > v1.4.0
> > > RC1.
> > >
> > > The release candidates:
> > >
> >
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.4.0-rc1/
> > > Git tag for the release:
> > > https://github.com/apache/dubbo-go-hessian2/tree/1.4
> > > Hash for the release tag: 4c31e88c35afe84c0321d9f12f036e6d3c8962d0
> > > Release Notes:
> > > https://github.com/apache/dubbo-go-hessian2/blob/1.4/CHANGE.md
> > > The artifacts have been signed with Key :7DB68550D366E4C0, which can
> be
> > > found in the keys file:
> > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > >
> > > The vote will be open for at least 72 hours or until necessary number
> of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thanks,
> > > The Apache Dubbo-go Team
> > >
> >
>
--
Regards,
Wongoo
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.4.0 RC1
Posted by Jun Liu <ke...@gmail.com>.
+1 binding
I checked:
* Signatures and hash are good
* NOTICE and LICENSE exists;
* Tests passed on my osx;
On Mon, Mar 9, 2020 at 11:19 AM Ian Luo <ia...@gmail.com> wrote:
> I checked the following items. I vote +1 (binding) to this release.
>
> [v] Are release files in correct location?
> [v] Are the digital signature and hashes correct?
> [v] Do LICENSE and NOTICE files exists?
> [v] Is the LICENSE and NOTICE text correct?
> [v] Is the NOTICE year correct?
> [x] Un-included software dependencies are not mentioned in LICENSE or
> NOTICE?
> [x] License information is not mentioned in NOTICE?
> [x] Is there any 3rd party code contained inside the release? If so:
> [ ] Does the software have a compatible license?
> [ ] Are all software licenses mentioned in LICENSE?
> [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
> Is any of this code Apache licensed? Do they have NOTICE files? If so:
> [ ] Have relevant parts of those NOTICE files been added to this NOTICE
> file?
> [ ] Do all source files have ASF headers?
> [v] Do the contents of the release match with what's tagged in version
> control?
> [x] Are there any unexpected binary files in the release?
> [v] Can you compile from source? Are the instruction clear?
>
> I vote with:
> [v] +1 release the software
> [ ] +0 not sure if it should be released
> [ ] -1 don’t release the software because..
>
> Regards,
> -Ian.
>
> On Fri, Mar 6, 2020 at 4:04 PM 望哥 <ge...@gmail.com> wrote:
>
> > Hello Dubbo/Dubbogo Community,
> >
> > This is a call for vote to release Apache dubbo-go-hessian2 version
> v1.4.0
> > RC1.
> >
> > The release candidates:
> >
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.4.0-rc1/
> > Git tag for the release:
> > https://github.com/apache/dubbo-go-hessian2/tree/1.4
> > Hash for the release tag: 4c31e88c35afe84c0321d9f12f036e6d3c8962d0
> > Release Notes:
> > https://github.com/apache/dubbo-go-hessian2/blob/1.4/CHANGE.md
> > The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo-go Team
> >
>
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.4.0 RC1
Posted by Ian Luo <ia...@gmail.com>.
I checked the following items. I vote +1 (binding) to this release.
[v] Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?
I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..
Regards,
-Ian.
On Fri, Mar 6, 2020 at 4:04 PM 望哥 <ge...@gmail.com> wrote:
> Hello Dubbo/Dubbogo Community,
>
> This is a call for vote to release Apache dubbo-go-hessian2 version v1.4.0
> RC1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.4.0-rc1/
> Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.4
> Hash for the release tag: 4c31e88c35afe84c0321d9f12f036e6d3c8962d0
> Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.4/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team
>