You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/08 17:50:36 UTC

[GitHub] apeforest commented on a change in pull request #13795: add extra header file to include

apeforest commented on a change in pull request #13795: add extra header file to include
URL: https://github.com/apache/incubator-mxnet/pull/13795#discussion_r246091839
 
 

 ##########
 File path: plugin/opencv/cv_api.cc
 ##########
 @@ -26,9 +26,9 @@
 #include <dmlc/base.h>
 #include <mxnet/base.h>
 #include <mxnet/ndarray.h>
+#include <mxnet/c_api_common.h>
 
 Review comment:
   I don't find a guideline for order. I was following the order of full path header followed by relative path header

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services