You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/27 20:13:34 UTC

[GitHub] [incubator-superset] ktmud commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs

ktmud commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r513000516



##########
File path: superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -275,6 +275,7 @@ export default class AdhocFilterControl extends React.Component {
           clearable
           closeOnSelect
           onChange={this.onChange}
+          onPaste={() => {}}

Review comment:
       `() => {}` doesn't really return an empty object. It's equivalent to `() => { return }`.
   
   <img src="https://user-images.githubusercontent.com/335541/97356668-d46afc00-1855-11eb-9cd2-2f6f98a55122.png" width="300">
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org