[GitHub] [metron] sardell edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases

[GitBox <gi...@apache.org>]

sardell edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases
URL: https://github.com/apache/metron/pull/1550#issuecomment-555538282
 
 
   @nickwallen Thanks for your help and the hot tip about running the failing part of the build to get better/more readable output.
   
   Something did change in the Node/NPM version upgrade. That `package-lock.json` file was introduced in NPM v5. Before my changes, the rpm and deb files in the project were using Node 6.x, which is bundled with NPM v3. With the up-to-date version of NPM, anywhere there is a `package.json` file, there should be a correlating `package-lock.json` to ensure NPM dependency versions match. It looks like we are using NPM for the express server in the RPM, so that `package-lock.json` file should be there as well. I'll add it to the metron.spec file. That should resolve my issue. Thanks for your help!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services