You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/08/30 16:05:02 UTC
[GitHub] [accumulo] dlmarion opened a new pull request, #2903: Added servers per host to cluster.yaml
dlmarion opened a new pull request, #2903:
URL: https://github.com/apache/accumulo/pull/2903
Added tservers_per_host and sservers_per_host to cluster.yaml file. This file is parsed
and transformed into environment variables that are read in by the accumulo-cluster script.
This change adds the environment variables NUM_TSERVERS and NUM_SSERVERS to the environment
with a default value of 1 if not specified in cluster.yaml and in a way that the value is
in cluster.yaml is overridden if the environment variable already exists in the environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a diff in pull request #2903: Added servers per host to cluster.yaml
Posted by GitBox <gi...@apache.org>.
keith-turner commented on code in PR #2903:
URL: https://github.com/apache/accumulo/pull/2903#discussion_r958826498
##########
assemble/bin/accumulo-cluster:
##########
@@ -121,8 +121,8 @@ function control_service() {
local last_instance_id
last_instance_id=1
- [[ $service == "tserver" ]] && last_instance_id=${NUM_TSERVERS:-1}
- [[ $service == "sserver" ]] && last_instance_id=${NUM_SSERVERS:-1}
+ [[ $service == "tserver" ]] && last_instance_id=${NUM_TSERVERS:-1} && echo "INFO: ${NUM_TSERVERS} tserver per host"
Review Comment:
Will this INFO message print for every host? Like if there are 300 tservers host, would it print for each one? Looking at the code it seems like it may, but not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #2903: Added servers per host to cluster.yaml
Posted by GitBox <gi...@apache.org>.
keith-turner commented on PR #2903:
URL: https://github.com/apache/accumulo/pull/2903#issuecomment-1232209578
> I can add some comments in the cluster.yaml file
That is probably the place where its most likely to be seen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2903: Added servers per host to cluster.yaml
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #2903:
URL: https://github.com/apache/accumulo/pull/2903#issuecomment-1232061014
> One thing I am wondering about is how will someone know about the NUM_TSERVER behavior? The behavior where if its set as an env var it will override whats in the cluster yaml file. Where should this be documented? Maybe a short paragraph in the accumulo_cluster script usage message?
Yeah, that's a good point. It wasn't really documented before either. I can add some comments in the cluster.yaml file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #2903: Added servers per host to cluster.yaml
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2903:
URL: https://github.com/apache/accumulo/pull/2903#discussion_r958841484
##########
assemble/bin/accumulo-cluster:
##########
@@ -121,8 +121,8 @@ function control_service() {
local last_instance_id
last_instance_id=1
- [[ $service == "tserver" ]] && last_instance_id=${NUM_TSERVERS:-1}
- [[ $service == "sserver" ]] && last_instance_id=${NUM_SSERVERS:-1}
+ [[ $service == "tserver" ]] && last_instance_id=${NUM_TSERVERS:-1} && echo "INFO: ${NUM_TSERVERS} tserver per host"
Review Comment:
I think it would be per host. I think I'll move this message in a follow-on commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #2903: Added servers per host to cluster.yaml
Posted by GitBox <gi...@apache.org>.
dlmarion merged PR #2903:
URL: https://github.com/apache/accumulo/pull/2903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org