You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/02 08:29:25 UTC
[jira] [Commented] (STORM-1677) Test resource files (.log) are
excluded from source distribution, which makes logviewer-test failing
[ https://issues.apache.org/jira/browse/STORM-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222748#comment-15222748 ]
ASF GitHub Bot commented on STORM-1677:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1300
STORM-1677 Test resource files are excluded from source distribution, which makes logviewer-test failing
* rename '.log' files to '.log.test' which can avoid exclusion when building source distribution
I can create pull request for 1.x-branch too, but just cherry-picking `d5e1112` would be easier if we cancel voting 1.0.0 RC1 and revert some commits.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1677
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1300
----
commit d5e11126a9c4082b66763bbd493a5b764c3a54ac
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-04-02T06:15:05Z
STORM-1677 Test resource files are excluded from source distribution, which makes logviewer-test failing
* rename '.log' files to '.log.test' which can avoid exclusion when building source distribution
----
> Test resource files (.log) are excluded from source distribution, which makes logviewer-test failing
> ----------------------------------------------------------------------------------------------------
>
> Key: STORM-1677
> URL: https://issues.apache.org/jira/browse/STORM-1677
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> While building RC1 of Apache Storm 1.0.0 from source code distribution, I found that test for logviewer-test in storm-core is failing. It was not intermittent.
> After seeking the reason, I found files on src/dev directory is different from repo, ".log" files are all excluded.
> https://github.com/apache/storm/blob/master/storm-dist/source/src/main/assembly/source.xml
> We excludes .log files in all directories which normally makes sense but not for now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)